[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 01/16] block: refactor bdrv_check_request: add errp
From: |
Eric Blake |
Subject: |
Re: [PATCH v4 01/16] block: refactor bdrv_check_request: add errp |
Date: |
Wed, 20 Jan 2021 16:20:41 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote:
> It's better to pass &error_abort than just assert that result is 0: on
> crash, we'll immediately see the reason in the backtrace.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> include/block/block_int.h | 2 +-
> block/file-posix.c | 2 +-
> block/io.c | 29 ++++++++++++++++++++++-------
> tests/test-write-threshold.c | 5 +++--
> 4 files changed, 27 insertions(+), 11 deletions(-)
>
> diff --git a/include/block/block_int.h b/include/block/block_int.h
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- Re: [PATCH v4 01/16] block: refactor bdrv_check_request: add errp,
Eric Blake <=