qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 1/2] scsi/utils: Add INVALID_PARAM_VALUE sense code defin


From: Philippe Mathieu-Daudé
Subject: Re: [RFC PATCH 1/2] scsi/utils: Add INVALID_PARAM_VALUE sense code definition
Date: Wed, 20 Jan 2021 17:04:22 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 1/20/21 5:01 PM, Gerd Hoffmann wrote:
>   Hi,
> 
>>> +/* Illegal request, Invalid value in parameter list */
>>> +extern const struct SCSISense sense_code_INVALID_PARAM_VALUE;
> 
>> Pre-existing: the term 'illegal' is suspect in computer science (the
>> code isn't breaking any laws);
> 
> Indeed.  It's named that way in the scsi specs though, and being
> consistent with that is a reasonable thing too ...

In v2 I renamed 'illegal' in the description comments but
not in the #definitions (which match the specs).

Regards,

Phil.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]