[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH V2 02/11] hw/block/nvme: open code for volatile write cac
From: |
Klaus Jensen |
Subject: |
Re: [RFC PATCH V2 02/11] hw/block/nvme: open code for volatile write cache |
Date: |
Mon, 18 Jan 2021 21:04:40 +0100 |
On Jan 17 23:53, Minwoo Im wrote:
> Volatile Write Cache(VWC) feature is set in nvme_ns_setup() in the
> initial time. This feature is related to block device backed, but this
> feature is controlled in controller level via Set/Get Features command.
>
> This patch removed dependency between nvme and nvme-ns to manage the VWC
> flag value. Also, it open coded the Get Features for VWC to check all
> namespaces attached to the controller, and if false detected, return
> directly false.
>
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
The VWC feature really should be namespace specific. I wonder why they
didn't fix that when they added an NSID to the Flush command...
Anyway, this is much better.
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
signature.asc
Description: PGP signature
- [RFC PATCH V2 00/11] hw/block/nvme: support multi-path for ctrl/ns, Minwoo Im, 2021/01/17
- [RFC PATCH V2 01/11] hw/block/nvme: remove unused argument in nvme_ns_init_zoned, Minwoo Im, 2021/01/17
- [RFC PATCH V2 02/11] hw/block/nvme: open code for volatile write cache, Minwoo Im, 2021/01/17
- [RFC PATCH V2 03/11] hw/block/nvme: remove unused argument in nvme_ns_init_blk, Minwoo Im, 2021/01/17
- [RFC PATCH V2 04/11] hw/block/nvme: split setup and register for namespace, Minwoo Im, 2021/01/17
- [RFC PATCH V2 05/11] hw/block/nvme: remove unused argument in nvme_ns_setup, Minwoo Im, 2021/01/17
- [RFC PATCH V2 06/11] hw/block/nvme: introduce nvme-subsys device, Minwoo Im, 2021/01/17
- [RFC PATCH V2 07/11] hw/block/nvme: support to map controller to a subsystem, Minwoo Im, 2021/01/17