[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 01/10] iotests.py: Assume a couple of variables as given
From: |
Willian Rampazzo |
Subject: |
Re: [PATCH v4 01/10] iotests.py: Assume a couple of variables as given |
Date: |
Fri, 15 Jan 2021 15:44:43 -0300 |
On Fri, Jan 15, 2021 at 2:43 PM Max Reitz <mreitz@redhat.com> wrote:
>
> There are a couple of environment variables that we fetch with
> os.environ.get() without supplying a default. Clearly they are required
> and expected to be set by the ./check script (as evidenced by
> execute_setup_common(), which checks for test_dir and
> qemu_default_machine to be set, and aborts if they are not).
>
> Using .get() this way has the disadvantage of returning an Optional[str]
> type, which mypy will complain about when tests just assume these values
> to be str.
>
> Use [] instead, which raises a KeyError for environment variables that
> are not set. When this exception is raised, catch it and move the abort
> code from execute_setup_common() there.
>
> Drop the 'assert iotests.sock_dir is not None' from iotest 300, because
> that sort of thing is precisely what this patch wants to prevent.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> tests/qemu-iotests/300 | 1 -
> tests/qemu-iotests/iotests.py | 26 +++++++++++++-------------
> 2 files changed, 13 insertions(+), 14 deletions(-)
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
- [PATCH v4 00/10] iotests: Fix 129 and expand 297’s reach, Max Reitz, 2021/01/15
- [PATCH v4 01/10] iotests.py: Assume a couple of variables as given, Max Reitz, 2021/01/15
- Re: [PATCH v4 01/10] iotests.py: Assume a couple of variables as given,
Willian Rampazzo <=
- [PATCH v4 02/10] iotests/297: Rewrite in Python and extend reach, Max Reitz, 2021/01/15
- [PATCH v4 03/10] iotests: Move try_remove to iotests.py, Max Reitz, 2021/01/15
- [PATCH v4 04/10] iotests/129: Remove test images in tearDown(), Max Reitz, 2021/01/15
- [PATCH v4 07/10] iotests/129: Actually test a commit job, Max Reitz, 2021/01/15
- [PATCH v4 09/10] iotests/129: Clean up pylint and mypy complaints, Max Reitz, 2021/01/15
- [PATCH v4 05/10] iotests/129: Do not check @busy, Max Reitz, 2021/01/15