[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 05/10] iotests/129: Do not check @busy
From: |
Willian Rampazzo |
Subject: |
Re: [PATCH v4 05/10] iotests/129: Do not check @busy |
Date: |
Fri, 15 Jan 2021 15:29:34 -0300 |
On Fri, Jan 15, 2021 at 2:43 PM Max Reitz <mreitz@redhat.com> wrote:
>
> @busy is false when the job is paused, which happens all the time
> because that is how jobs yield (e.g. for mirror at least since commit
> 565ac01f8d3).
>
> Back when 129 was added (2015), perhaps there was no better way of
> checking whether the job was still actually running. Now we have the
> @status field (as of 58b295ba52c, i.e. 2018), which can give us exactly
> that information.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> tests/qemu-iotests/129 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
- [PATCH v4 02/10] iotests/297: Rewrite in Python and extend reach, (continued)
- [PATCH v4 02/10] iotests/297: Rewrite in Python and extend reach, Max Reitz, 2021/01/15
- [PATCH v4 03/10] iotests: Move try_remove to iotests.py, Max Reitz, 2021/01/15
- [PATCH v4 04/10] iotests/129: Remove test images in tearDown(), Max Reitz, 2021/01/15
- [PATCH v4 07/10] iotests/129: Actually test a commit job, Max Reitz, 2021/01/15
- [PATCH v4 09/10] iotests/129: Clean up pylint and mypy complaints, Max Reitz, 2021/01/15
- [PATCH v4 05/10] iotests/129: Do not check @busy, Max Reitz, 2021/01/15
- Re: [PATCH v4 05/10] iotests/129: Do not check @busy,
Willian Rampazzo <=
- [PATCH v4 06/10] iotests/129: Use throttle node, Max Reitz, 2021/01/15
- [PATCH v4 10/10] iotests/300: Clean up pylint and mypy complaints, Max Reitz, 2021/01/15
- [PATCH v4 08/10] iotests/129: Limit mirror job's buffer size, Max Reitz, 2021/01/15