Hi Michael,
On Wed, Dec 02, 2020 at 03:26:07PM +0000, Stefan Hajnoczi wrote:
>v2:
> * Print errors [Marc-André]
>
>Markus Armbruster pointed out that g_return_val_if() is meant for programming
>errors. It must not be used for input validation since it can be compiled out.
>Use explicit if statements instead.
>
>This patch series converts vhost-user device backends that use
>g_return_val_if() in get/set_config().
>
>Stefan Hajnoczi (4):
> contrib/vhost-user-blk: avoid g_return_val_if() input validation
> contrib/vhost-user-gpu: avoid g_return_val_if() input validation
> contrib/vhost-user-input: avoid g_return_val_if() input validation
> block/export: avoid g_return_val_if() input validation
>
> block/export/vhost-user-blk-server.c | 6 +++++-
> contrib/vhost-user-blk/vhost-user-blk.c | 6 +++++-
> contrib/vhost-user-gpu/vhost-user-gpu.c | 6 +++++-
> contrib/vhost-user-input/main.c | 6 +++++-
> 4 files changed, 20 insertions(+), 4 deletions(-)
>
>--
>2.28.0
>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
You didn't collect the v2 patch series, with the received reviewed-by. Not a big deal here, but please be more careful.
thanks
--
Marc-André Lureau