[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 10/21] block: add bdrv_list_* permission update functions
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH 10/21] block: add bdrv_list_* permission update functions |
Date: |
Mon, 23 Nov 2020 23:12:22 +0300 |
Add new interface, allowing use of existing node list. It will be used
to fix bdrv_replace_node() in the following commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
block.c | 112 ++++++++++++++++++++++++++++++++++++++------------------
1 file changed, 76 insertions(+), 36 deletions(-)
diff --git a/block.c b/block.c
index 799c475dda..d799afeedd 100644
--- a/block.c
+++ b/block.c
@@ -2154,7 +2154,8 @@ static int bdrv_drv_set_perm(BlockDriverState *bs,
uint64_t perm,
static int bdrv_node_check_perm(BlockDriverState *bs, BlockReopenQueue *q,
uint64_t cumulative_perms,
uint64_t cumulative_shared_perms,
- GSList *ignore_children, Error **errp)
+ GSList *ignore_children,
+ GSList **tran, Error **errp)
{
int ret;
BlockDriver *drv = bs->drv;
@@ -2202,7 +2203,7 @@ static int bdrv_node_check_perm(BlockDriverState *bs,
BlockReopenQueue *q,
return 0;
}
- ret = bdrv_drv_set_perm(bs, cumulative_perms, cumulative_shared_perms,
NULL,
+ ret = bdrv_drv_set_perm(bs, cumulative_perms, cumulative_shared_perms,
tran,
errp);
if (ret < 0) {
return ret;
@@ -2221,36 +2222,53 @@ static int bdrv_node_check_perm(BlockDriverState *bs,
BlockReopenQueue *q,
bdrv_child_perm(bs, c->bs, c, c->role, q,
cumulative_perms, cumulative_shared_perms,
&cur_perm, &cur_shared);
- bdrv_child_set_perm_safe(c, cur_perm, cur_shared, NULL);
+ bdrv_child_set_perm_safe(c, cur_perm, cur_shared, tran);
}
return 0;
}
-static int bdrv_check_perm(BlockDriverState *bs, BlockReopenQueue *q,
- uint64_t cumulative_perms,
- uint64_t cumulative_shared_perms,
- GSList *ignore_children, Error **errp)
+/*
+ * If use_cumulative_perms is true, use cumulative_perms and
+ * cumulative_shared_perms for first element of the list. Otherwise just
refresh
+ * all permissions.
+ */
+static int bdrv_check_perm_common(GSList *list, BlockReopenQueue *q,
+ bool use_cumulative_perms,
+ uint64_t cumulative_perms,
+ uint64_t cumulative_shared_perms,
+ GSList *ignore_children,
+ GSList **tran, Error **errp)
{
int ret;
- BlockDriverState *root = bs;
- g_autoptr(GSList) list = bdrv_topological_dfs(NULL, NULL, root);
+ BlockDriverState *bs;
- for ( ; list; list = list->next) {
+ if (use_cumulative_perms) {
bs = list->data;
- if (bs != root) {
- if (!bdrv_check_parents_compliance(bs, ignore_children, errp)) {
- return -EINVAL;
- }
+ ret = bdrv_node_check_perm(bs, q, cumulative_perms,
+ cumulative_shared_perms,
+ ignore_children, tran, errp);
+ if (ret < 0) {
+ return ret;
+ }
+
+ list = list->next;
+ }
- bdrv_get_cumulative_perm(bs, &cumulative_perms,
- &cumulative_shared_perms);
+ for ( ; list; list = list->next) {
+ bs = list->data;
+
+ if (!bdrv_check_parents_compliance(bs, ignore_children, errp)) {
+ return -EINVAL;
}
+ bdrv_get_cumulative_perm(bs, &cumulative_perms,
+ &cumulative_shared_perms);
+
ret = bdrv_node_check_perm(bs, q, cumulative_perms,
cumulative_shared_perms,
- ignore_children, errp);
+ ignore_children, tran, errp);
if (ret < 0) {
return ret;
}
@@ -2259,6 +2277,22 @@ static int bdrv_check_perm(BlockDriverState *bs,
BlockReopenQueue *q,
return 0;
}
+static int bdrv_check_perm(BlockDriverState *bs, BlockReopenQueue *q,
+ uint64_t cumulative_perms,
+ uint64_t cumulative_shared_perms,
+ GSList *ignore_children, Error **errp)
+{
+ g_autoptr(GSList) list = bdrv_topological_dfs(NULL, NULL, bs);
+ return bdrv_check_perm_common(list, q, true, cumulative_perms,
+ cumulative_shared_perms, ignore_children,
+ NULL, errp);
+}
+
+static int bdrv_list_check_perm(GSList *list, GSList **tran, Error **errp)
+{
+ return bdrv_check_perm_common(list, NULL, false, 0, 0, NULL, tran, errp);
+}
+
/*
* Notifies drivers that after a previous bdrv_check_perm() call, the
* permission update is not performed and any preparations made for it (e.g.
@@ -2280,15 +2314,19 @@ static void
bdrv_node_abort_perm_update(BlockDriverState *bs)
}
}
-static void bdrv_abort_perm_update(BlockDriverState *bs)
+static void bdrv_list_abort_perm_update(GSList *list)
{
- g_autoptr(GSList) list = bdrv_topological_dfs(NULL, NULL, bs);
-
for ( ; list; list = list->next) {
bdrv_node_abort_perm_update((BlockDriverState *)list->data);
}
}
+static void bdrv_abort_perm_update(BlockDriverState *bs)
+{
+ g_autoptr(GSList) list = bdrv_topological_dfs(NULL, NULL, bs);
+ return bdrv_list_abort_perm_update(list);
+}
+
static void bdrv_node_set_perm(BlockDriverState *bs)
{
BlockDriver *drv = bs->drv;
@@ -2312,15 +2350,19 @@ static void bdrv_node_set_perm(BlockDriverState *bs)
}
}
-static void bdrv_set_perm(BlockDriverState *bs)
+static void bdrv_list_set_perm(GSList *list)
{
- g_autoptr(GSList) list = bdrv_topological_dfs(NULL, NULL, bs);
-
for ( ; list; list = list->next) {
bdrv_node_set_perm((BlockDriverState *)list->data);
}
}
+static void bdrv_set_perm(BlockDriverState *bs)
+{
+ g_autoptr(GSList) list = bdrv_topological_dfs(NULL, NULL, bs);
+ return bdrv_list_set_perm(list);
+}
+
void bdrv_get_cumulative_perm(BlockDriverState *bs, uint64_t *perm,
uint64_t *shared_perm)
{
@@ -2425,23 +2467,21 @@ static int bdrv_check_update_perm(BlockDriverState *bs,
BlockReopenQueue *q,
ignore_children, errp);
}
-static int bdrv_refresh_perms(BlockDriverState *bs, Error **errp)
+static int bdrv_list_refresh_perms(GSList *list, Error **errp)
{
int ret;
- uint64_t perm, shared_perm;
+ GSList *tran = NULL;
- if (!bdrv_check_parents_compliance(bs, NULL, errp)) {
- return -EPERM;
- }
- bdrv_get_cumulative_perm(bs, &perm, &shared_perm);
- ret = bdrv_check_perm(bs, NULL, perm, shared_perm, NULL, errp);
- if (ret < 0) {
- bdrv_abort_perm_update(bs);
- return ret;
- }
- bdrv_set_perm(bs);
+ ret = bdrv_list_check_perm(list, &tran, errp);
+ tran_finalize(tran, ret);
- return 0;
+ return ret;
+}
+
+static int bdrv_refresh_perms(BlockDriverState *bs, Error **errp)
+{
+ g_autoptr(GSList) list = bdrv_topological_dfs(NULL, NULL, bs);
+ return bdrv_list_refresh_perms(list, errp);
}
int bdrv_child_try_set_perm(BdrvChild *c, uint64_t perm, uint64_t shared,
--
2.21.3
- Re: [PATCH 2/2] block: assert that permission commit sets same permissions, (continued)
- [PATCH 02/21] tests/test-bdrv-graph-mod: add test_parallel_perm_update, Vladimir Sementsov-Ogievskiy, 2020/11/23
- [PATCH 03/21] util: add transactions.c, Vladimir Sementsov-Ogievskiy, 2020/11/23
- [PATCH 04/21] block: bdrv_refresh_perms: check parents compliance, Vladimir Sementsov-Ogievskiy, 2020/11/23
- [PATCH 06/21] block: rewrite bdrv_child_try_set_perm() using bdrv_refresh_perms(), Vladimir Sementsov-Ogievskiy, 2020/11/23
- [PATCH 07/21] block: inline bdrv_child_*() permission functions calls, Vladimir Sementsov-Ogievskiy, 2020/11/23
- [PATCH 08/21] block: use topological sort for permission update, Vladimir Sementsov-Ogievskiy, 2020/11/23
- [PATCH 05/21] block: refactor bdrv_child* permission functions, Vladimir Sementsov-Ogievskiy, 2020/11/23
- [PATCH 09/21] block: add bdrv_drv_set_perm transaction action, Vladimir Sementsov-Ogievskiy, 2020/11/23
- [PATCH 10/21] block: add bdrv_list_* permission update functions,
Vladimir Sementsov-Ogievskiy <=
- [PATCH 11/21] block: add bdrv_replace_child_safe() transaction action, Vladimir Sementsov-Ogievskiy, 2020/11/23
- [PATCH 12/21] block: return value from bdrv_replace_node(), Vladimir Sementsov-Ogievskiy, 2020/11/23
- [PATCH 13/21] block: fix bdrv_replace_node_common, Vladimir Sementsov-Ogievskiy, 2020/11/23
- [PATCH 15/21] block: split out bdrv_replace_node_noperm(), Vladimir Sementsov-Ogievskiy, 2020/11/23
- [PATCH 14/21] block: add bdrv_attach_child_noperm() transaction action, Vladimir Sementsov-Ogievskiy, 2020/11/23
- [PATCH 16/21] block: bdrv_append(): don't consume reference, Vladimir Sementsov-Ogievskiy, 2020/11/23
- [PATCH 19/21] block: add bdrv_remove_backing transaction action, Vladimir Sementsov-Ogievskiy, 2020/11/23
- [PATCH 21/21] block/backup-top: drop .active, Vladimir Sementsov-Ogievskiy, 2020/11/23
- [PATCH 17/21] block: bdrv_append(): return status, Vladimir Sementsov-Ogievskiy, 2020/11/23
- [PATCH 18/21] block: adapt bdrv_append() for inserting filters, Vladimir Sementsov-Ogievskiy, 2020/11/23