qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-5.2 04/10] vhost-user-blk-test: rename destroy_drive() to


From: Max Reitz
Subject: Re: [PATCH for-5.2 04/10] vhost-user-blk-test: rename destroy_drive() to destroy_file()
Date: Thu, 12 Nov 2020 15:32:58 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0

On 11.11.20 13:43, Stefan Hajnoczi wrote:
The function is used not just for image files but also for UNIX domain
sockets (QMP monitor and vhost-user-blk). Reflect that in the name.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
  tests/qtest/vhost-user-blk-test.c | 9 +++++----
  1 file changed, 5 insertions(+), 4 deletions(-)

[...]

@@ -731,7 +732,7 @@ static char *start_vhost_user_blk(GString *cmd_line, int 
vus_instances,
          sock_path = g_strdup(sock_path_tempate);
          fd = mkstemp(sock_path);
          g_assert_cmpint(fd, >=, 0);
-        g_test_queue_destroy(drive_destroy, sock_path);
+        g_test_queue_destroy(drive_file, sock_path);

s/drive_file/destroy_file/, I think :)

          /* create image file */
          img_path = drive_create();
          g_string_append_printf(storage_daemon_command,





reply via email to

[Prev in Thread] Current Thread [Next in Thread]