[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-5.2 05/10] vhost-user-blk-test: close fork child file descrip
From: |
Stefan Hajnoczi |
Subject: |
[PATCH for-5.2 05/10] vhost-user-blk-test: close fork child file descriptors |
Date: |
Wed, 11 Nov 2020 12:43:26 +0000 |
Do not leave stdin and stdout open after fork. stdout is the
tap-driver.pl pipe. If we keep the pipe open then tap-driver.pl will not
detect that qos-test has terminated and it will hang.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
tests/qtest/vhost-user-blk-test.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/tests/qtest/vhost-user-blk-test.c
b/tests/qtest/vhost-user-blk-test.c
index f05f14c192..4019a72ac0 100644
--- a/tests/qtest/vhost-user-blk-test.c
+++ b/tests/qtest/vhost-user-blk-test.c
@@ -749,6 +749,15 @@ static char *start_vhost_user_blk(GString *cmd_line, int
vus_instances,
storage_daemon_command->str);
pid_t pid = fork();
if (pid == 0) {
+ /*
+ * Close standard file descriptors so tap-driver.pl pipe detects when
+ * our parent terminates.
+ */
+ close(0);
+ close(1);
+ open("/dev/null", O_RDONLY);
+ open("/dev/null", O_WRONLY);
+
execlp("/bin/sh", "sh", "-c", storage_daemon_command->str, NULL);
exit(1);
}
--
2.28.0
- [PATCH for-5.2 00/10] block/export: vhost-user-blk server tests and input validation, Stefan Hajnoczi, 2020/11/11
- [PATCH for-5.2 01/10] test: new qTest case to test the vhost-user-blk-server, Stefan Hajnoczi, 2020/11/11
- [PATCH for-5.2 02/10] tests/qtest: add multi-queue test case to vhost-user-blk-test, Stefan Hajnoczi, 2020/11/11
- [PATCH for-5.2 03/10] libqtest: add qtest_socket_server(), Stefan Hajnoczi, 2020/11/11
- [PATCH for-5.2 04/10] vhost-user-blk-test: rename destroy_drive() to destroy_file(), Stefan Hajnoczi, 2020/11/11
- [PATCH for-5.2 05/10] vhost-user-blk-test: close fork child file descriptors,
Stefan Hajnoczi <=
- [PATCH for-5.2 06/10] vhost-user-blk-test: drop unused return value, Stefan Hajnoczi, 2020/11/11
- [PATCH for-5.2 07/10] vhost-user-blk-test: fix races by using fd passing, Stefan Hajnoczi, 2020/11/11
- [PATCH for-5.2 08/10] block/export: port virtio-blk discard/write zeroes input validation, Stefan Hajnoczi, 2020/11/11
- [PATCH for-5.2 09/10] vhost-user-blk-test: test discard/write zeroes invalid inputs, Stefan Hajnoczi, 2020/11/11
- [PATCH for-5.2 10/10] block/export: port virtio-blk read/write range check, Stefan Hajnoczi, 2020/11/11
- Re: [PATCH for-5.2 00/10] block/export: vhost-user-blk server tests and input validation, Michael S. Tsirkin, 2020/11/17