Re: [PULL 5/7] tests.acceptance: adds simple migration test

[Philippe Mathieu-Daudé]

Hi,

On Fri, Feb 22, 2019 at 8:42 PM Cleber Rosa <crosa@redhat.com> wrote:
>
> From: Caio Carrara <ccarrara@redhat.com>
>
> This change adds the simplest possible migration test. Beyond the test
> purpose itself it's also useful to exercise the multi virtual machines
> capabilities from base avocado qemu test class.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> Signed-off-by: Caio Carrara <ccarrara@redhat.com>
> Reviewed-by: Cleber Rosa <crosa@redhat.com>
> Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> Message-Id: <20190212193855.13223-3-ccarrara@redhat.com>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>  tests/acceptance/migration.py | 53 +++++++++++++++++++++++++++++++++++
>  1 file changed, 53 insertions(+)
>  create mode 100644 tests/acceptance/migration.py
>
> diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py
> new file mode 100644
> index 0000000000..6115cf6c24
> --- /dev/null
> +++ b/tests/acceptance/migration.py
> @@ -0,0 +1,53 @@
> +# Migration test
> +#
> +# Copyright (c) 2019 Red Hat, Inc.
> +#
> +# Authors:
> +#  Cleber Rosa <crosa@redhat.com>
> +#  Caio Carrara <ccarrara@redhat.com>
> +#
> +# This work is licensed under the terms of the GNU GPL, version 2 or
> +# later.  See the COPYING file in the top-level directory.
> +
> +
> +from avocado_qemu import Test
> +
> +from avocado.utils import network
> +from avocado.utils import wait
> +
> +
> +class Migration(Test):
> +    """
> +    :avocado: enable
> +    """
> +
> +    timeout = 10
> +
> +    @staticmethod
> +    def migration_finished(vm):
> +        return vm.command('query-migrate')['status'] in ('completed', 
> 'failed')
> +
> +    def _get_free_port(self):
> +        port = network.find_free_port()
> +        if port is None:
> +            self.cancel('Failed to find a free port')
> +        return port

This method doesn't seem to work when running with -j2: 2 tests started
with different arch configurations get the same port... Is this a known issue?

> +
> +
> +    def test_migration_with_tcp_localhost(self):
> +        source_vm = self.get_vm()
> +        dest_uri = 'tcp:localhost:%u' % self._get_free_port()
> +        dest_vm = self.get_vm('-incoming', dest_uri)
> +        dest_vm.launch()
> +        source_vm.launch()
> +        source_vm.qmp('migrate', uri=dest_uri)
> +        wait.wait_for(
> +            self.migration_finished,
> +            timeout=self.timeout,
> +            step=0.1,
> +            args=(source_vm,)
> +        )
> +        self.assertEqual(dest_vm.command('query-migrate')['status'], 
> 'completed')
> +        self.assertEqual(source_vm.command('query-migrate')['status'], 
> 'completed')
> +        self.assertEqual(dest_vm.command('query-status')['status'], 
> 'running')
> +        self.assertEqual(source_vm.command('query-status')['status'], 
> 'postmigrate')
> --
> 2.20.1
>