[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/25] block/nvme: Move definitions before structure declarat
From: |
Auger Eric |
Subject: |
Re: [PATCH 09/25] block/nvme: Move definitions before structure declarations |
Date: |
Wed, 28 Oct 2020 11:44:05 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
Hi,
On 10/27/20 2:55 PM, Philippe Mathieu-Daudé wrote:
> To be able to use some definitions in structure declarations,
> move them earlier. No logical change.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Eric
> ---
> block/nvme.c | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/block/nvme.c b/block/nvme.c
> index be14350f959..30075e230ca 100644
> --- a/block/nvme.c
> +++ b/block/nvme.c
> @@ -41,6 +41,16 @@
>
> typedef struct BDRVNVMeState BDRVNVMeState;
>
> +/* Same index is used for queues and IRQs */
> +#define INDEX_ADMIN 0
> +#define INDEX_IO(n) (1 + n)
> +
> +/* This driver shares a single MSIX IRQ for the admin and I/O queues */
> +enum {
> + MSIX_SHARED_IRQ_IDX = 0,
> + MSIX_IRQ_COUNT = 1
> +};
> +
> typedef struct {
> int32_t head, tail;
> uint8_t *queue;
> @@ -81,15 +91,6 @@ typedef struct {
> QEMUBH *completion_bh;
> } NVMeQueuePair;
>
> -#define INDEX_ADMIN 0
> -#define INDEX_IO(n) (1 + n)
> -
> -/* This driver shares a single MSIX IRQ for the admin and I/O queues */
> -enum {
> - MSIX_SHARED_IRQ_IDX = 0,
> - MSIX_IRQ_COUNT = 1
> -};
> -
> struct BDRVNVMeState {
> AioContext *aio_context;
> QEMUVFIOState *vfio;
>
- [PATCH 06/25] block/nvme: Improve nvme_free_req_queue_wait() trace information, (continued)
- [PATCH 06/25] block/nvme: Improve nvme_free_req_queue_wait() trace information, Philippe Mathieu-Daudé, 2020/10/27
- [PATCH 07/25] block/nvme: Trace queue pair creation/deletion, Philippe Mathieu-Daudé, 2020/10/27
- [PATCH 12/25] block/nvme: Make nvme_init_queue() return boolean indicating error, Philippe Mathieu-Daudé, 2020/10/27
- [PATCH 09/25] block/nvme: Move definitions before structure declarations, Philippe Mathieu-Daudé, 2020/10/27
- [PATCH 08/25] block/nvme: Simplify device reset, Philippe Mathieu-Daudé, 2020/10/27
[PATCH 10/25] block/nvme: Use unsigned integer for queue counter/size, Philippe Mathieu-Daudé, 2020/10/27