[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 02/30] pci: pass along the return value of dma_memory_rw
From: |
Klaus Jensen |
Subject: |
Re: [PULL 02/30] pci: pass along the return value of dma_memory_rw |
Date: |
Tue, 27 Oct 2020 12:10:44 +0100 |
On Oct 27 11:49, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Some devices might want to know the return value of dma_memory_rw, so
> pass it along instead of ignoring it.
>
> There are no existing users of the return value, so this patch should be
> safe.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> Acked-by: Keith Busch <kbusch@kernel.org>
> ---
> include/hw/pci/pci.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
> index 0a59a06b149d..f19ffe6b4fe8 100644
> --- a/include/hw/pci/pci.h
> +++ b/include/hw/pci/pci.h
> @@ -783,8 +783,7 @@ static inline AddressSpace
> *pci_get_address_space(PCIDevice *dev)
> static inline int pci_dma_rw(PCIDevice *dev, dma_addr_t addr,
> void *buf, dma_addr_t len, DMADirection dir)
> {
> - dma_memory_rw(pci_get_address_space(dev), addr, buf, len, dir);
> - return 0;
> + return dma_memory_rw(pci_get_address_space(dev), addr, buf, len, dir);
> }
>
> static inline int pci_dma_read(PCIDevice *dev, dma_addr_t addr,
> --
> 2.29.1
>
Philippe posted a series where this patch is included as well (with a
couple of additional reviews I think). Merging that is probably
preferable, and I can respin this pull.
signature.asc
Description: PGP signature
- [PULL 00/30] nvme emulation patches for 5.2, Klaus Jensen, 2020/10/27
- [PULL 03/30] hw/block/nvme: handle dma errors, Klaus Jensen, 2020/10/27
- [PULL 01/30] hw/block/nvme: fix typo in trace event, Klaus Jensen, 2020/10/27
- [PULL 04/30] hw/block/nvme: commonize nvme_rw error handling, Klaus Jensen, 2020/10/27
- [PULL 02/30] pci: pass along the return value of dma_memory_rw, Klaus Jensen, 2020/10/27
- Re: [PULL 02/30] pci: pass along the return value of dma_memory_rw,
Klaus Jensen <=
- [PULL 06/30] hw/block/nvme: add a lba to bytes helper, Klaus Jensen, 2020/10/27
- [PULL 08/30] hw/block/nvme: add symbolic command name to trace events, Klaus Jensen, 2020/10/27
- [PULL 05/30] hw/block/nvme: alignment style fixes, Klaus Jensen, 2020/10/27
- [PULL 07/30] hw/block/nvme: fix endian conversion, Klaus Jensen, 2020/10/27
- [PULL 09/30] hw/block/nvme: refactor aio submission, Klaus Jensen, 2020/10/27
- [PULL 10/30] hw/block/nvme: default request status to success, Klaus Jensen, 2020/10/27
- [PULL 11/30] hw/block/nvme: harden cmb access, Klaus Jensen, 2020/10/27
- [PULL 14/30] hw/block/nvme: refactor identify active namespace id list, Klaus Jensen, 2020/10/27
- [PULL 13/30] hw/block/nvme: add support for sgl bit bucket descriptor, Klaus Jensen, 2020/10/27
- [PULL 12/30] hw/block/nvme: add support for scatter gather lists, Klaus Jensen, 2020/10/27