[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 12/17] hw/block/nvme: add support for scatter gather lists
|
From: |
Klaus Jensen |
|
Subject: |
Re: [PATCH v3 12/17] hw/block/nvme: add support for scatter gather lists |
|
Date: |
Fri, 23 Oct 2020 08:27:39 +0200 |
On Oct 22 22:51, Philippe Mathieu-Daudé wrote:
> On 9/22/20 10:45 AM, Klaus Jensen wrote:
> > +static uint16_t nvme_dma(NvmeCtrl *n, uint8_t *ptr, uint32_t len,
>
> Using a 'void *ptr' would simplify your API, avoiding the callers
> to cast.
>
You are correct, but there is a bunch of work being done on top of
nvme-next right now - so even though it is not in master yet, I'd rather
not make too many fixups that trickles down like this.
But I will queue something up for this.
signature.asc
Description: PGP signature