[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/16] util/vfio-helpers: Convert vfio_dump_mapping to trace
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH 09/16] util/vfio-helpers: Convert vfio_dump_mapping to trace events |
Date: |
Thu, 22 Oct 2020 15:20:44 +0100 |
On Tue, Oct 20, 2020 at 07:24:21PM +0200, Philippe Mathieu-Daudé wrote:
> The QEMU_VFIO_DEBUG definition is only modifiable at build-time.
> Trace events can be enabled at run-time. As we prefer the latter,
> convert qemu_vfio_dump_mappings() to use trace events instead
> of fprintf().
>
> Reviewed-by: Fam Zheng <fam@euphon.net>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> util/vfio-helpers.c | 19 ++++---------------
> util/trace-events | 1 +
> 2 files changed, 5 insertions(+), 15 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature
- Re: [PATCH 04/16] util/vfio-helpers: Report error when IOMMU page size is not supported, (continued)
- [PATCH 05/16] util/vfio-helpers: Trace PCI I/O config accesses, Philippe Mathieu-Daudé, 2020/10/20
- [PATCH 06/16] util/vfio-helpers: Trace PCI BAR region info, Philippe Mathieu-Daudé, 2020/10/20
- [PATCH 07/16] util/vfio-helpers: Trace where BARs are mapped, Philippe Mathieu-Daudé, 2020/10/20
- [PATCH 08/16] util/vfio-helpers: Improve DMA trace events, Philippe Mathieu-Daudé, 2020/10/20
- [PATCH 09/16] util/vfio-helpers: Convert vfio_dump_mapping to trace events, Philippe Mathieu-Daudé, 2020/10/20
- Re: [PATCH 09/16] util/vfio-helpers: Convert vfio_dump_mapping to trace events,
Stefan Hajnoczi <=
- [PATCH 10/16] util/vfio-helpers: Let qemu_vfio_dma_map() propagate Error, Philippe Mathieu-Daudé, 2020/10/20
- [PATCH 11/16] util/vfio-helpers: Let qemu_vfio_do_mapping() propagate Error, Philippe Mathieu-Daudé, 2020/10/20
- [PATCH 12/16] util/vfio-helpers: Let qemu_vfio_verify_mappings() use error_report(), Philippe Mathieu-Daudé, 2020/10/20
- [PATCH 13/16] util/vfio-helpers: Introduce qemu_vfio_pci_msix_init_irqs(), Philippe Mathieu-Daudé, 2020/10/20
- [PATCH 14/16] util/vfio-helpers: Introduce qemu_vfio_pci_msix_set_irq(), Philippe Mathieu-Daudé, 2020/10/20