Re: [PATCH v11 11/13] stream: mark backing-file argument as deprecated

[Andrey Shinkevich]

On 14.10.2020 18:43, Vladimir Sementsov-Ogievskiy wrote:
> 14.10.2020 18:03, Max Reitz wrote:
> > On 12.10.20 19:43, Andrey Shinkevich wrote:
> > > Whereas the block-stream job starts using a backing file name of the
> > > base node overlay after the block-stream job completes, mark the QMP
> > > 'backing-file' argument as deprecated.
> > >
> > > Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
> > > ---
> > >   docs/system/deprecated.rst | 6 ++++++
> > >   1 file changed, 6 insertions(+)
> > >
> > > diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> > > index 8b3ab5b..7491fcf 100644
> > > --- a/docs/system/deprecated.rst
> > > +++ b/docs/system/deprecated.rst
> > > @@ -285,6 +285,12 @@ details.
> > >   The ``query-events`` command has been superseded by the more powerful
> > >   and accurate ``query-qmp-schema`` command.
> > > +``block-stream`` argument ``backing-file`` (since 5.2)
> > > +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
> > > +
> > > +The argument ``backing-file`` is deprecated. QEMU uses a backing file
> > > +name of the base node overlay after the block-stream job completes.
> > > +
> >
> > Hm, why?  I don’t see the problem with it.
>
> My wrong idea, sorry. I believed that the argument is unused when I were 
> reviewing v10. But it actually become unused during the series and it is 
> wrong.

I missed searching for calls to the qmp_block_stream() in the QEMU 
dinamically generated code. Will roll back.

Andrey