Re: [PATCH v4 3/7] keyval: Fix parsing of ', ' in value of implied key

[Eric Blake]

On 10/11/20 2:35 AM, Markus Armbruster wrote:
> The previous commit demonstrated documentation and code disagree on
> parsing of ',' in the value of an implied key.  Fix the code to match
> the documentation.
>
> This breaks uses of keyval_parse() that pass an implied key and accept
> a value containing ','.  None of the existing uses does:
>
> * audiodev: implied key "driver" is enum AudiodevDriver, none of the
>    values contains ','
>
> * display: implied key "type" is enum DisplayType, none of the values
>    contains ','
>
> * blockdev: implied key "driver is enum BlockdevDriver, none of the
>    values contains ','
>
> * export: implied key "type" is enum BlockExportType, none of the
>    values contains ','
>
> * monitor: implied key "mode" is enum MonitorMode, none of the values
>    contains ','
>
> * nbd-server: no implied key.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   tests/test-keyval.c |  8 +++-----
>   util/keyval.c       | 28 +++++++++++++++++-----------
>   2 files changed, 20 insertions(+), 16 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org