[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 10/20] iotests.py: Adjust HMP kwargs typing
From: |
John Snow |
Subject: |
[PATCH 10/20] iotests.py: Adjust HMP kwargs typing |
Date: |
Tue, 6 Oct 2020 19:58:07 -0400 |
mypy wants to ensure there's consistency between the kwargs arguments
types and any unspecified keyword arguments. In this case, conv_keys is
a bool, but the remaining keys are Any type. Mypy (correctly) infers the
**kwargs type to be **Dict[str, str], which is not compatible with
conv_keys: bool.
Because QMP typing is a little fraught right now anyway, re-type kwargs
to Dict[str, Any] which has the benefit of silencing this check right
now.
A future re-design might type these more aggressively, but this will
give us a baseline to work from with minimal disruption.
(Thanks Kevin Wolf for the debugging assist here)
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
---
tests/qemu-iotests/iotests.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index f212cec446d..63d2ace93c0 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -605,7 +605,7 @@ def add_incoming(self, addr):
def hmp(self, command_line: str, use_log: bool = False) -> QMPMessage:
cmd = 'human-monitor-command'
- kwargs = {'command-line': command_line}
+ kwargs: Dict[str, Any] = {'command-line': command_line}
if use_log:
return self.qmp_log(cmd, **kwargs)
else:
--
2.26.2
- Re: [PATCH 08/20] python/machine.py: fix _popen access, (continued)
[PATCH 09/20] python/qemu: make 'args' style arguments immutable, John Snow, 2020/10/06
[PATCH 05/20] python/machine.py: Handle None events in events_wait, John Snow, 2020/10/06
[PATCH 07/20] python/machine.py: Add _qmp access shim, John Snow, 2020/10/06
[PATCH 06/20] python/machine.py: use qmp.command, John Snow, 2020/10/06
[PATCH 10/20] iotests.py: Adjust HMP kwargs typing,
John Snow <=
[PATCH 11/20] python/qemu: Add mypy type annotations, John Snow, 2020/10/06
[PATCH 12/20] python/qemu/console_socket.py: Correct type of recv(), John Snow, 2020/10/06
[PATCH 14/20] python/qemu/console_socket.py: Clarify type of drain_thread, John Snow, 2020/10/06
[PATCH 13/20] python/qemu/console_socket.py: fix typing of settimeout, John Snow, 2020/10/06