[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/1] hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTER
|
From: |
Laszlo Ersek |
|
Subject: |
Re: [PATCH v3 1/1] hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE |
|
Date: |
Tue, 6 Oct 2020 18:16:05 +0200 |
On 10/06/20 18:08, Philippe Mathieu-Daudé wrote:
> On 10/6/20 6:04 PM, Laszlo Ersek wrote:
>> On 10/06/20 17:51, Richard Henderson wrote:
>>> On 10/6/20 10:36 AM, Philippe Mathieu-Daudé wrote:
>>>> +++ b/hw/nvram/fw_cfg-interface.c
>>>> @@ -0,0 +1,15 @@
>>>> +#include "qemu/osdep.h"
>>>> +#include "hw/nvram/fw_cfg.h"
>>>
>>> License boilerplate missing.
>>>
>>> r~
>>>
>>
>> Hrmpf, so easy to forget about that, especially in review :/
>
> Although easily scriptable if we consider SPDX identifiers...
... Hm, "scripts/checkpatch.pl" already checks for SPDX, but only as an
exception to the ban on "//" comments :) See commit 8d061278d385
("checkpatch: allow SPDX-License-Identifier", 2019-06-03).
Laszlo
Re: [PATCH v3 0/1] qom: Fix missing interface in qemu-storage-daemon, no-reply, 2020/10/06