[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/6] block/nvme: Reduce I/O registers scope
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v2 3/6] block/nvme: Reduce I/O registers scope |
Date: |
Fri, 25 Sep 2020 16:34:06 +0100 |
On Tue, Sep 22, 2020 at 10:38:18AM +0200, Philippe Mathieu-Daudé wrote:
> @@ -808,6 +808,10 @@ static int nvme_init(BlockDriverState *bs, const char
> *device, int namespace,
> ret = -EIO;
> }
> out:
> + if (regs) {
> + qemu_vfio_pci_unmap_bar(s->vfio, 0, (void *)regs, 0,
> sizeof(NvmeBar));
> + }
qemu_vfio_pci_unmap_bar(NULL) is a nop, so the check is unnecessary. I
didn't look to see whether the doorbells can be NULL too during unmap,
but if yes, then it's clearer to be consistent (always check NULL or
never check NULL).
Not worth respinning though.
signature.asc
Description: PGP signature
- [PATCH v2 0/6] block/nvme: Map doorbells pages write-only, remove magic from nvme_init, Philippe Mathieu-Daudé, 2020/09/22
- [PATCH v2 1/6] util/vfio-helpers: Pass page protections to qemu_vfio_pci_map_bar(), Philippe Mathieu-Daudé, 2020/09/22
- [PATCH v2 2/6] block/nvme: Map doorbells pages write-only, Philippe Mathieu-Daudé, 2020/09/22
- [PATCH v2 3/6] block/nvme: Reduce I/O registers scope, Philippe Mathieu-Daudé, 2020/09/22
- Re: [PATCH v2 3/6] block/nvme: Reduce I/O registers scope,
Stefan Hajnoczi <=
- [PATCH v2 4/6] block/nvme: Drop NVMeRegs structure, directly use NvmeBar, Philippe Mathieu-Daudé, 2020/09/22
- [PATCH v2 5/6] block/nvme: Use register definitions from 'block/nvme.h', Philippe Mathieu-Daudé, 2020/09/22
- [PATCH v2 6/6] block/nvme: Replace magic value by SCALE_MS definition, Philippe Mathieu-Daudé, 2020/09/22
- Re: [PATCH v2 0/6] block/nvme: Map doorbells pages write-only, remove magic from nvme_init, no-reply, 2020/09/22
- Re: [PATCH v2 0/6] block/nvme: Map doorbells pages write-only, remove magic from nvme_init, Fam Zheng, 2020/09/22
- Re: [PATCH v2 0/6] block/nvme: Map doorbells pages write-only, remove magic from nvme_init, Stefan Hajnoczi, 2020/09/25