|
From: | Alberto Garcia |
Subject: | Re: [PATCH v2 10/13] block/qcow2-bitmap: return status from qcow2_store_persistent_dirty_bitmaps |
Date: | Fri, 18 Sep 2020 17:21:46 +0200 |
User-agent: | Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 17 Sep 2020 09:55:16 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > It's better to return status together with setting errp. It makes > possible to avoid error propagation. > > While being here, put ERRP_GUARD() to fix error_prepend(errp, ...) > usage inside qcow2_store_persistent_dirty_bitmaps() (see the comment > above ERRP_GUARD() definition in include/qapi/error.h) > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > Reviewed-by: Greg Kurz <groug@kaod.org> Reviewed-by: Alberto Garcia <berto@igalia.com> Berto
[Prev in Thread] | Current Thread | [Next in Thread] |