[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 04/21] curses: Fixes curses compiling errors.
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2 04/21] curses: Fixes curses compiling errors. |
Date: |
Wed, 9 Sep 2020 14:26:18 +0100 |
On Wed, 9 Sep 2020 at 10:46, Yonggang Luo <luoyonggang@gmail.com> wrote:
>
> This is the compiling error:
> ../ui/curses.c: In function 'curses_refresh':
> ../ui/curses.c:256:5: error: 'next_maybe_keycode' may be used uninitialized
> in this function [-Werror=maybe-uninitialized]
> 256 | curses2foo(_curses2keycode, _curseskey2keycode, chr,
> maybe_keycode)
> | ^~~~~~~~~~
> ../ui/curses.c:302:32: note: 'next_maybe_keycode' was declared here
> 302 | enum maybe_keycode next_maybe_keycode;
> | ^~~~~~~~~~~~~~~~~~
> ../ui/curses.c:256:5: error: 'maybe_keycode' may be used uninitialized in
> this function [-Werror=maybe-uninitialized]
> 256 | curses2foo(_curses2keycode, _curseskey2keycode, chr,
> maybe_keycode)
> | ^~~~~~~~~~
> ../ui/curses.c:265:24: note: 'maybe_keycode' was declared here
> 265 | enum maybe_keycode maybe_keycode;
> | ^~~~~~~~~~~~~
> cc1.exe: all warnings being treated as errors
>
> gcc version 10.2.0 (Rev1, Built by MSYS2 project)
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
I never gave this a reviewed-by tag -- can you be more careful
with your tag handling, please?
thanks
-- PMM
- Re: [PATCH v2 01/21] block: Fixes nfs compiling error on msys2/mingw, (continued)
- [PATCH v2 04/21] curses: Fixes curses compiling errors., Yonggang Luo, 2020/09/09
- [PATCH v2 05/21] tests: disable /char/stdio/* tests in test-char.c on win32, Yonggang Luo, 2020/09/09
- [PATCH v2 06/21] ci: Enable msys2 ci in cirrus, Yonggang Luo, 2020/09/09
- [PATCH v2 07/21] tests: Trying fixes test-replication.c on msys2/mingw., Yonggang Luo, 2020/09/09
- [PATCH v2 08/21] tests: test-replication disable /replication/secondary/* on msys2/mingw., Yonggang Luo, 2020/09/09