[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 20/21] tests: fix test-util-sockets.c
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2 20/21] tests: fix test-util-sockets.c |
Date: |
Wed, 9 Sep 2020 14:11:46 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Wed, Sep 09, 2020 at 05:46:16PM +0800, Yonggang Luo wrote:
> Fixes following errors:
> Running test test-util-sockets
> ERROR test-util-sockets - missing test plan
>
> # Start of name tests
> **
> ERROR:../tests/test-util-sockets.c:93:test_socket_fd_pass_name_good:
> assertion failed (fd != -1): (-1 != -1)
> Bail out!
> ERROR:../tests/test-util-sockets.c:93:test_socket_fd_pass_name_good:
> assertion failed (fd != -1): (-1 != -1)
>
> First should call to qemu_init_main_loop before socket_init,
> then on win32 doesn't support for SOCKET_ADDRESS_TYPE_FD socket type
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
> tests/test-util-sockets.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH v2 14/21] cirrus: Building freebsd in a single short, (continued)
- [PATCH v2 15/21] tests: Convert g_free to g_autofree macro in test-logging.c, Yonggang Luo, 2020/09/09
- [PATCH v2 16/21] rcu: add uninit destructor for rcu, Yonggang Luo, 2020/09/09
- [PATCH v2 17/21] tests: Fixes test-io-channel-socket.c tests under msys2/mingw, Yonggang Luo, 2020/09/09
- [PATCH v2 18/21] tests: fixes aio-win32 about aio_remove_fd_handler, get it consistence with aio-posix.c, Yonggang Luo, 2020/09/09
- [PATCH v2 19/21] tests: Fixes test-io-channel-file by mask only owner file state mask bits, Yonggang Luo, 2020/09/09
- [PATCH v2 20/21] tests: fix test-util-sockets.c, Yonggang Luo, 2020/09/09
- Re: [PATCH v2 20/21] tests: fix test-util-sockets.c,
Daniel P . Berrangé <=
- [PATCH v2 21/21] tests: Fixes test-qdev-global-props.c, Yonggang Luo, 2020/09/09