[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 09/21] osdep: These function are only available on Non-Win
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2 09/21] osdep: These function are only available on Non-Win32 system. |
Date: |
Wed, 9 Sep 2020 13:59:30 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
Reword the subject to say
"osdep: file locking functions are not available on Win32"
On Wed, Sep 09, 2020 at 05:46:05PM +0800, Yonggang Luo wrote:
> int qemu_lock_fd(int fd, int64_t start, int64_t len, bool exclusive);
> int qemu_unlock_fd(int fd, int64_t start, int64_t len);
> int qemu_lock_fd_test(int fd, int64_t start, int64_t len, bool exclusive);
> bool qemu_has_ofd_lock(void);
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
> include/qemu/osdep.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
> index 412962d91a..e80fddd1e8 100644
> --- a/include/qemu/osdep.h
> +++ b/include/qemu/osdep.h
> @@ -502,11 +502,11 @@ int qemu_close(int fd);
> int qemu_unlink(const char *name);
> #ifndef _WIN32
> int qemu_dup(int fd);
> -#endif
> int qemu_lock_fd(int fd, int64_t start, int64_t len, bool exclusive);
> int qemu_unlock_fd(int fd, int64_t start, int64_t len);
> int qemu_lock_fd_test(int fd, int64_t start, int64_t len, bool exclusive);
> bool qemu_has_ofd_lock(void);
> +#endif
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH v2 05/21] tests: disable /char/stdio/* tests in test-char.c on win32, (continued)
- [PATCH v2 06/21] ci: Enable msys2 ci in cirrus, Yonggang Luo, 2020/09/09
- [PATCH v2 07/21] tests: Trying fixes test-replication.c on msys2/mingw., Yonggang Luo, 2020/09/09
- [PATCH v2 08/21] tests: test-replication disable /replication/secondary/* on msys2/mingw., Yonggang Luo, 2020/09/09
- [PATCH v2 09/21] osdep: These function are only available on Non-Win32 system., Yonggang Luo, 2020/09/09
- Re: [PATCH v2 09/21] osdep: These function are only available on Non-Win32 system.,
Daniel P . Berrangé <=
- [PATCH v2 10/21] meson: Use -b to ignore CR vs. CR-LF issues on Windows, Yonggang Luo, 2020/09/09
- [PATCH v2 11/21] meson: disable crypto tests are empty under win32, Yonggang Luo, 2020/09/09
- [PATCH v2 12/21] meson: remove empty else and duplicated gio deps, Yonggang Luo, 2020/09/09
- [PATCH v2 13/21] vmstate: Fixes test-vmstate.c on msys2/mingw, Yonggang Luo, 2020/09/09
- [PATCH v2 14/21] cirrus: Building freebsd in a single short, Yonggang Luo, 2020/09/09