Re: make -i check resut for msys2

[Thomas Huth]

On 04/09/2020 00.53, 罗勇刚(Yonggang Luo) wrote:
> 
> 
> On Thu, Sep 3, 2020 at 10:33 PM Thomas Huth <thuth@redhat.com
> <mailto:thuth@redhat.com>> wrote:
> 
>     On 03/09/2020 11.18, 罗勇刚(Yonggang Luo) wrote:
>     [...]
>     >   TEST    check-unit: tests/test-replication.exe
>     > **
>     > ERROR:C:/work/xemu/qemu/tests/test-replication.c:136:make_temp:
>     > assertion failed: (fd >= 0)
>     > ERROR test-replication.exe - Bail out!
>     > ERROR:C:/work/xemu/qemu/tests/test-replication.c:136:make_temp:
>     > assertion failed: (fd >= 0)
> 
>     At least this one should be easy to fix: The test uses /tmp as
>     hard-coded directory for temporary files. I think it should use
>     g_get_tmp_dir() from glib to get that directory instead.
> 
>      Thomas
> 
> After fixes tmp path, how to fixes following error:
> $ tests/test-replication.exe                                            
>                                                                        
>                                                                        
>          
> # random seed: R02Sdf2e4ffc0e6fbe96624598386b538927
> 1..13
> # Start of replication tests
> # Start of primary tests
> Unexpected error in bdrv_open_inherit() at ../block.c:3456:
> Block protocol 'file' doesn't support the option 'locking' 

Not sure ... as a temporary test, try to remove the "locking=off"
strings from the test. If it then works, it might be worth discussing
with the block layer folks how to handle this test on Windows in the
best way. If it still does not work, it's maybe simply not worth the
effort to try to get this test running on Windows - and thus mark it
with CONFIG_POSIX in the Makefile / meson.build.

 Thomas