[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/7] block: Use definitions instead of magic values
From: |
Laurent Vivier |
Subject: |
Re: [PATCH 0/7] block: Use definitions instead of magic values |
Date: |
Tue, 1 Sep 2020 11:27:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
Le 14/08/2020 à 10:28, Philippe Mathieu-Daudé a écrit :
> Trivial block patches:
> - Fix a typo
> - Replace '1 << 30' by '1 * GiB' in null-co
> - Replace 512 by BDRV_SECTOR_SIZE when appropriate.
>
> Philippe Mathieu-Daudé (7):
> block/null: Make more explicit the driver default size is 1GiB
> hw/ide/core: Trivial typo fix
> hw/ide/core: Replace magic '512' value by BDRV_SECTOR_SIZE
> hw/ide/ahci: Replace magic '512' value by BDRV_SECTOR_SIZE
> hw/ide/atapi: Replace magic '512' value by BDRV_SECTOR_SIZE
> hw/ide/pci: Replace magic '512' value by BDRV_SECTOR_SIZE
> hw/scsi/scsi-disk: Replace magic '512' value by BDRV_SECTOR_SIZE
>
> block/null.c | 4 +++-
> hw/ide/ahci.c | 5 +++--
> hw/ide/atapi.c | 8 ++++----
> hw/ide/core.c | 25 +++++++++++++------------
> hw/ide/pci.c | 2 +-
> hw/scsi/scsi-disk.c | 44 +++++++++++++++++++++++---------------------
> 6 files changed, 47 insertions(+), 41 deletions(-)
>
Applied to my trivial-patches branch.
Except the following ones that have comment from Kevin:
[PATCH 1/7] block/null: Make more explicit the driver default size is 1GiB
[PATCH 3/7] hw/ide/core: Replace magic '512' value by BDRV_SECTOR_SIZE
Thanks,
Laurent
- Re: [PATCH 0/7] block: Use definitions instead of magic values,
Laurent Vivier <=