qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 14/47] stream: Deal with filters


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v7 14/47] stream: Deal with filters
Date: Thu, 20 Aug 2020 13:49:31 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

20.08.2020 12:22, Max Reitz wrote:
On 20.08.20 10:31, Max Reitz wrote:

[...]

So all in all, I believe the biggest surprise about what’s written into
the top layer isn’t that it may be a json:{} filename, but the filename
of a node that maybe doesn’t even exist anymore?  (Oh, no, please don’t
tell me you can delete it and get an invalid pointer read...)

(I tried triggering that, but, oh, it’s strdup’ed() in stream_start().
I’m a bit daft.)



If it's broken anyway, probably we can just revert c624b015bf and start to 
freeze base again?


--
Best regards,
Vladimir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]