Re: [PATCH v13 09/11] qcow2_format.py: collect fields to dump in JSON format

[Vladimir Sementsov-Ogievskiy]

07.08.2020 11:03, Andrey Shinkevich wrote:
> On 07.08.2020 09:30, Vladimir Sementsov-Ogievskiy wrote:
> > 06.08.2020 22:35, Andrey Shinkevich wrote:
> > > As __dict__ is being extended with class members we do not want to
> > > print, add the to_dict() method to classes that returns a dictionary
> >
> > to_json() ... that returns a json-dumpable object
>
> New version to release with the commit message fix?

Not worth resending, it can be touched when queuing.

> > > with desired fields and their values. Extend it in subclass when
> > > necessary to print the final dictionary in the JSON output which
> > > follows.
> > >
> > > Suggested-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > > Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
> >
> > Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>


--
Best regards,
Vladimir