|
From: | Vladimir Sementsov-Ogievskiy |
Subject: | Re: [PATCH v2 3/4] iotests: Add more qemu_img helpers |
Date: | Tue, 28 Jul 2020 16:50:12 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
28.07.2020 00:58, Nir Soffer wrote:
Add 2 helpers for measuring and checking images: - qemu_img_measure() - qemu_img_check() Both use --output-json and parse the returned json to make easy to use in other tests. I'm going to use them in a new test, and I hope they will be useful in may other tests. Signed-off-by: Nir Soffer <nsoffer@redhat.com> --- tests/qemu-iotests/iotests.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 8f79668435..717b5b652c 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -141,6 +141,12 @@ def qemu_img_create(*args):return qemu_img(*args) +def qemu_img_measure(*args):+ return json.loads(qemu_img_pipe("measure", "--output", "json", *args)) + +def qemu_img_check(*args): + return json.loads(qemu_img_pipe("check", "--output", "json", *args)) +
qemu_img_pipe has type hints, so I assume we should add them here too. Also, qemu-img don't report errors in json format, so in case of error, this will raise a problem about something that json can't parse. Probably we need better error handling. Still, for 5.1 it's OK as is I think, so if we are in a hurry: Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
def qemu_img_verbose(*args): '''Run qemu-img without suppressing its output and return the exit code''' exitcode = subprocess.call(qemu_img_args + list(args))
-- Best regards, Vladimir
[Prev in Thread] | Current Thread | [Next in Thread] |