Re: [PATCH v2 11/20] qapi: backup: add x-max-chunk and x-max-workers parameters

[Max Reitz]

On 22.07.20 14:22, Max Reitz wrote:
> On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
>> Add new parameters to configure future backup features. The patch
>> doesn't introduce aio backup requests (so we actually have only one
>> worker) neither requests larger than one cluster. Still, formally we
>> satisfy these maximums anyway, so add the parameters now, to facilitate
>> further patch which will really change backup job behavior.
>>
>> Options are added with x- prefixes, as the only use for them are some
>> very conservative iotests which will be updated soon.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> ---
>>  qapi/block-core.json      |  9 ++++++++-
>>  include/block/block_int.h |  7 +++++++
>>  block/backup.c            | 21 +++++++++++++++++++++
>>  block/replication.c       |  2 +-
>>  blockdev.c                |  5 +++++
>>  5 files changed, 42 insertions(+), 2 deletions(-)

[...]

>> diff --git a/block/replication.c b/block/replication.c
>> index 25987eab0f..a9ee82db80 100644
>> --- a/block/replication.c
>> +++ b/block/replication.c
>> @@ -563,7 +563,7 @@ static void replication_start(ReplicationState *rs, 
>> ReplicationMode mode,
>>          s->backup_job = backup_job_create(
>>                                  NULL, s->secondary_disk->bs, 
>> s->hidden_disk->bs,
>>                                  0, MIRROR_SYNC_MODE_NONE, NULL, 0, false, 
>> NULL,
>> -                                true,
>> +                                true, 0, 0,
> 
> Passing 0 for max_workers will error out immediately, won’t it?

Ah, oops.  Saw your own reply only now.  Yep, 1 worker would be nice. :)

signature.asc
Description: OpenPGP digital signature