Re: [PATCH v11 31/34] qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit

[Max Reitz]

On 10.07.20 18:13, Alberto Garcia wrote:
> Now that the implementation of subclusters is complete we can finally
> add the necessary options to create and read images with this feature,
> which we call "extended L2 entries".
> 
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> ---
>  qapi/block-core.json             |   7 +++
>  block/qcow2.h                    |   8 ++-
>  include/block/block_int.h        |   1 +
>  block/qcow2.c                    |  66 ++++++++++++++++++--
>  tests/qemu-iotests/031.out       |   8 +--
>  tests/qemu-iotests/036.out       |   4 +-
>  tests/qemu-iotests/049.out       | 102 +++++++++++++++----------------
>  tests/qemu-iotests/060.out       |   1 +
>  tests/qemu-iotests/061.out       |  20 +++---
>  tests/qemu-iotests/065           |  12 ++--
>  tests/qemu-iotests/082.out       |  39 +++++++++---
>  tests/qemu-iotests/085.out       |  38 ++++++------
>  tests/qemu-iotests/144.out       |   4 +-
>  tests/qemu-iotests/182.out       |   2 +-
>  tests/qemu-iotests/185.out       |   8 +--
>  tests/qemu-iotests/198           |   2 +

Oh, yes.  198, not 191.  Sorry.

>  tests/qemu-iotests/206.out       |   4 ++
>  tests/qemu-iotests/242.out       |   5 ++
>  tests/qemu-iotests/255.out       |   8 +--
>  tests/qemu-iotests/274.out       |  49 ++++++++-------
>  tests/qemu-iotests/280.out       |   2 +-
>  tests/qemu-iotests/291.out       |   2 +
>  tests/qemu-iotests/common.filter |   1 +
>  23 files changed, 253 insertions(+), 140 deletions(-)

Looks good.  Some of the patches in Kevin’s block branch will inevitably
require some more churn, but all of it looks obvious to resolve.

Max

signature.asc
Description: OpenPGP digital signature