[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] trivial: Remove trailing whitespaces
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH] trivial: Remove trailing whitespaces |
Date: |
Tue, 7 Jul 2020 11:25:10 +0100 |
User-agent: |
Mutt/1.14.3 (2020-06-14) |
On Mon, Jul 06, 2020 at 06:23:00PM +0200, Christophe de Dinechin wrote:
> There are a number of unnecessary trailing whitespaces that have
> accumulated over time in the source code. They cause stray changes
> in patches if you use tools that automatically remove them.
>
> Tested by doing a `git diff -w` after the change.
>
> This could probably be turned into a pre-commit hook.
scripts/checkpatch.pl ought to be made to check it.
>
> Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
> ---
> block/iscsi.c | 2 +-
> disas/cris.c | 2 +-
> disas/microblaze.c | 80 +++---
> disas/nios2.c | 256 +++++++++---------
> hmp-commands.hx | 2 +-
> hw/alpha/typhoon.c | 6 +-
> hw/arm/gumstix.c | 6 +-
> hw/arm/omap1.c | 2 +-
> hw/arm/stellaris.c | 2 +-
> hw/char/etraxfs_ser.c | 2 +-
> hw/core/ptimer.c | 2 +-
> hw/cris/axis_dev88.c | 2 +-
> hw/cris/boot.c | 2 +-
> hw/display/qxl.c | 2 +-
> hw/dma/etraxfs_dma.c | 18 +-
> hw/dma/i82374.c | 2 +-
> hw/i2c/bitbang_i2c.c | 2 +-
> hw/input/tsc2005.c | 2 +-
> hw/input/tsc210x.c | 2 +-
> hw/intc/etraxfs_pic.c | 8 +-
> hw/intc/sh_intc.c | 10 +-
> hw/intc/xilinx_intc.c | 2 +-
> hw/misc/imx25_ccm.c | 6 +-
> hw/misc/imx31_ccm.c | 2 +-
> hw/net/vmxnet3.h | 2 +-
> hw/net/xilinx_ethlite.c | 2 +-
> hw/pci/pcie.c | 2 +-
> hw/sd/omap_mmc.c | 2 +-
> hw/sh4/shix.c | 2 +-
> hw/sparc64/sun4u.c | 2 +-
> hw/timer/etraxfs_timer.c | 2 +-
> hw/timer/xilinx_timer.c | 4 +-
> hw/usb/hcd-musb.c | 10 +-
> hw/usb/hcd-ohci.c | 6 +-
> hw/usb/hcd-uhci.c | 2 +-
> hw/virtio/virtio-pci.c | 2 +-
> include/hw/cris/etraxfs_dma.h | 4 +-
> include/hw/net/lance.h | 2 +-
> include/hw/ppc/spapr.h | 2 +-
> include/hw/xen/interface/io/ring.h | 34 +--
> include/qemu/log.h | 2 +-
> include/qom/object.h | 4 +-
> linux-user/cris/cpu_loop.c | 16 +-
> linux-user/microblaze/cpu_loop.c | 16 +-
> linux-user/mmap.c | 8 +-
> linux-user/sparc/signal.c | 4 +-
> linux-user/syscall.c | 24 +-
> linux-user/syscall_defs.h | 2 +-
> linux-user/uaccess.c | 2 +-
> os-posix.c | 2 +-
> qapi/qapi-util.c | 2 +-
> qemu-img.c | 2 +-
> qemu-options.hx | 26 +-
> qom/object.c | 2 +-
> target/cris/translate.c | 28 +-
> target/cris/translate_v10.inc.c | 6 +-
> target/i386/hvf/hvf.c | 4 +-
> target/i386/hvf/x86.c | 4 +-
> target/i386/hvf/x86_decode.c | 20 +-
> target/i386/hvf/x86_decode.h | 4 +-
> target/i386/hvf/x86_descr.c | 2 +-
> target/i386/hvf/x86_emu.c | 2 +-
> target/i386/hvf/x86_mmu.c | 6 +-
> target/i386/hvf/x86_task.c | 2 +-
> target/i386/hvf/x86hvf.c | 42 +--
> target/i386/translate.c | 8 +-
> target/microblaze/mmu.c | 2 +-
> target/microblaze/translate.c | 2 +-
> target/sh4/op_helper.c | 4 +-
> target/xtensa/core-de212/core-isa.h | 6 +-
> .../xtensa/core-sample_controller/core-isa.h | 6 +-
> target/xtensa/core-test_kc705_be/core-isa.h | 2 +-
> tcg/sparc/tcg-target.inc.c | 2 +-
> tcg/tcg.c | 32 +--
> tests/tcg/multiarch/test-mmap.c | 72 ++---
> ui/curses.c | 4 +-
> ui/curses_keys.h | 4 +-
> util/cutils.c | 2 +-
> 78 files changed, 440 insertions(+), 440 deletions(-)
The cleanup is a good idea, however, I think it is probably better to
split the patch approx into subsystems. That will make it much easier
to cherry-pick for people doing backports.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|