qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v3 00/18] hw/block/nvme: bump to v1.3


From: Klaus Jensen
Subject: [PATCH v3 00/18] hw/block/nvme: bump to v1.3
Date: Mon, 6 Jul 2020 08:12:45 +0200

From: Klaus Jensen <k.jensen@samsung.com>

This adds mandatory features of NVM Express v1.3 to the emulated NVMe
device.


v3:
  * hw/block/nvme: additional tracing
    - Reverse logic in nvme_cid(). (Philippe)
    - Move nvme_cid() and nvme_sqid() to source file. (Philippe)
  * hw/block/nvme: fix missing endian conversion
    - Move this patch to very early in the series and fix the bug properly as
      suggested by Philippe. Then let the change trickle down through
      the series. (Philippe)
  * hw/block/nvme: add remaining mandatory controller parameters
    - Move the nvme_feature_{support,default} arrays to the source file.
      (Philippe)
    - Add a NVME_FID_MAX constant. (Philippe)
  * hw/block/nvme: support the get/set features select and save fields
    - Move the nvme_feature_cap array to the source file. (Philippe)
  * hw/block/nvme: reject invalid nsid values in active namespace id list
    - Rework the condition and add a comment and reference to the spec.
      (Philippe)
  * hw/block/nvme: provide the mandatory subnqn field
    - Change to use strpadcpy(). (Philippe)

  Had to clear some R-b's due to functional changes.

  Missing review: 2, 3, 7, 12, 16, 17


v2:
  * hw/block/nvme: bump spec data structures to v1.3
    - Shorten some constants. (Dmitry)
  * hw/block/nvme: add temperature threshold feature
    - Remove unused temp_thresh member. (Dmitry)
  * hw/block/nvme: add support for the get log page command
    - Change the temperature field in the NvmeSmartLog struct to be an
      uint16_t and handle wierd alignment by adding QEMU_PACKED to the
      struct. (Dmitry)
  * hw/block/nvme: add remaining mandatory controller parameters
    - Fix spelling. (Dmitry)
  * hw/block/nvme: support the get/set features select and save fields
    - Fix bad logic causing temperature thresholds to always report
      defaults. (Dmitry)
  * hw/block/nvme: reject invalid nsid values in active namespace id list
    - Added patch; reject the 0xfffffffe and 0xffffffff nsid values.


$ git-backport-diff -u for-master/bump-to-v1.3-v2 -r upstream/master... -S
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/18:[----] [--] 'hw/block/nvme: bump spec data structures to v1.3'
002/18:[0008] [FC] 'hw/block/nvme: fix missing endian conversion'
003/18:[0028] [FC] 'hw/block/nvme: additional tracing'
004/18:[----] [--] 'hw/block/nvme: add support for the abort command'
005/18:[0004] [FC] 'hw/block/nvme: add temperature threshold feature'
006/18:[----] [--] 'hw/block/nvme: mark fw slot 1 as read-only'
007/18:[----] [--] 'hw/block/nvme: add support for the get log page command'
008/18:[0002] [FC] 'hw/block/nvme: add support for the asynchronous event 
request command'
009/18:[----] [--] 'hw/block/nvme: move NvmeFeatureVal into hw/block/nvme.h'
010/18:[----] [--] 'hw/block/nvme: flush write cache when disabled'
011/18:[0044] [FC] 'hw/block/nvme: add remaining mandatory controller 
parameters'
012/18:[0024] [FC] 'hw/block/nvme: support the get/set features select and save 
fields'
013/18:[----] [--] 'hw/block/nvme: make sure ncqr and nsqr is valid'
014/18:[----] [--] 'hw/block/nvme: support identify namespace descriptor list'
015/18:[0008] [FC] 'hw/block/nvme: reject invalid nsid values in active 
namespace id list'
016/18:[----] [--] 'hw/block/nvme: enforce valid queue creation sequence'
017/18:[0006] [FC] 'hw/block/nvme: provide the mandatory subnqn field'
018/18:[----] [--] 'hw/block/nvme: bump supported version to v1.3'


Klaus Jensen (18):
  hw/block/nvme: bump spec data structures to v1.3
  hw/block/nvme: fix missing endian conversion
  hw/block/nvme: additional tracing
  hw/block/nvme: add support for the abort command
  hw/block/nvme: add temperature threshold feature
  hw/block/nvme: mark fw slot 1 as read-only
  hw/block/nvme: add support for the get log page command
  hw/block/nvme: add support for the asynchronous event request command
  hw/block/nvme: move NvmeFeatureVal into hw/block/nvme.h
  hw/block/nvme: flush write cache when disabled
  hw/block/nvme: add remaining mandatory controller parameters
  hw/block/nvme: support the get/set features select and save fields
  hw/block/nvme: make sure ncqr and nsqr is valid
  hw/block/nvme: support identify namespace descriptor list
  hw/block/nvme: reject invalid nsid values in active namespace id list
  hw/block/nvme: enforce valid queue creation sequence
  hw/block/nvme: provide the mandatory subnqn field
  hw/block/nvme: bump supported version to v1.3

 block/nvme.c          |  18 +-
 hw/block/nvme.c       | 676 ++++++++++++++++++++++++++++++++++++++++--
 hw/block/nvme.h       |  22 +-
 hw/block/trace-events |  27 +-
 include/block/nvme.h  | 225 +++++++++++---
 5 files changed, 892 insertions(+), 76 deletions(-)

-- 
2.27.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]