[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 15/17] hw/sd/sdcard: Correctly display the command name in
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v7 15/17] hw/sd/sdcard: Correctly display the command name in trace events |
|
Date: |
Fri, 3 Jul 2020 17:09:15 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/3/20 3:28 PM, Peter Maydell wrote:
> On Tue, 30 Jun 2020 at 14:39, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> Some ACMD were incorrectly displayed. Fix by remembering if we
>> are processing a ACMD (with current_cmd_is_acmd) and add the
>> sd_current_cmd_name() helper, which display to correct name
>> regardless it is a CMD or ACMD.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> I think my comments on v3 of this patch still apply:
> https://patchew.org/QEMU/20200605102230.21493-1-philmd@redhat.com/20200605102230.21493-10-philmd@redhat.com/
I agree with your comments. I didn't addressed them because for some
unknown reason this mail ended tagged as spam. I'll address that now.
Thanks for reviewing the rest of this series!
>
> thanks
> -- PMM
>