[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 28/34] qcow2: Add subcluster support to qcow2_co_pwrite_ze
|
From: |
Max Reitz |
|
Subject: |
Re: [PATCH v9 28/34] qcow2: Add subcluster support to qcow2_co_pwrite_zeroes() |
|
Date: |
Fri, 3 Jul 2020 09:18:32 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 |
On 03.07.20 00:40, Alberto Garcia wrote:
> On Thu 02 Jul 2020 04:28:57 PM CEST, Max Reitz wrote:
>>> + /* For full clusters use zero_in_l2_slice() instead */
>>> + assert(nb_subclusters > 0 && nb_subclusters <
>>> s->subclusters_per_cluster);
>>> + assert(sc + nb_subclusters <= s->subclusters_per_cluster);
>>
>> Maybe we should also assert that @offset is aligned to the subcluster
>> size.
>
> It doesn't hurt but the only caller already guarantees that already ...
Sure, but it also guarantees the rest of these conditions, doesn’t it? :)
Max
signature.asc
Description: OpenPGP digital signature