[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 16/17] hw/block/nvme: provide the mandatory subnqn field
From: |
Dmitry Fomichev |
Subject: |
Re: [PATCH 16/17] hw/block/nvme: provide the mandatory subnqn field |
Date: |
Fri, 3 Jul 2020 00:47:10 +0000 |
User-agent: |
Evolution 3.32.5 (3.32.5-1.fc30) |
Looks good,
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
On Mon, 2020-06-29 at 20:26 +0200, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> The SUBNQN field is mandatory in NVM Express 1.3.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
> ---
> hw/block/nvme.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 798f6f30e7da..9f0b9de73307 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -2131,6 +2131,9 @@ static void nvme_init_ctrl(NvmeCtrl *n, PCIDevice
> *pci_dev)
> id->oncs = cpu_to_le16(NVME_ONCS_WRITE_ZEROS | NVME_ONCS_TIMESTAMP |
> NVME_ONCS_FEATURES);
>
> + pstrcpy((char *) id->subnqn, sizeof(id->subnqn),
> "nqn.2019-08.org.qemu:");
> + pstrcat((char *) id->subnqn, sizeof(id->subnqn), n->params.serial);
> +
> id->psd[0].mp = cpu_to_le16(0x9c4);
> id->psd[0].enlat = cpu_to_le32(0x10);
> id->psd[0].exlat = cpu_to_le32(0x4);
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 16/17] hw/block/nvme: provide the mandatory subnqn field,
Dmitry Fomichev <=