[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 21/34] qcow2: Add subcluster support to qcow2_get_host_off
|
From: |
Alberto Garcia |
|
Subject: |
Re: [PATCH v9 21/34] qcow2: Add subcluster support to qcow2_get_host_offset() |
|
Date: |
Fri, 03 Jul 2020 00:04:00 +0200 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 02 Jul 2020 02:46:27 PM CEST, Max Reitz wrote:
>> - /* must be allocated */
>> - assert(first_cluster_type == QCOW2_CLUSTER_NORMAL ||
>> - first_cluster_type == QCOW2_CLUSTER_ZERO_ALLOC);
>> + assert(*l2_index + nb_clusters <= s->l2_size);
>
> Not l2_slice_size?
Oh, indeed!
>> + } else if (check_offset) {
>
> My gcc (v10.1.1) appears to be a bit daft, and so doesn’t recognize
> that check_offset must always be initialized before this line is hit.
Yeah I noticed that patchew complained, I'll fix that.
Berto