[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/12] block/nvme: clarify that free_req_queue is protected by q->
From: |
Stefan Hajnoczi |
Subject: |
[PULL 10/12] block/nvme: clarify that free_req_queue is protected by q->lock |
Date: |
Wed, 24 Jun 2020 11:02:08 +0100 |
Existing users access free_req_queue under q->lock. Document this.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Sergio Lopez <slp@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20200617132201.1832152-6-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block/nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/nvme.c b/block/nvme.c
index 8e60882af3..426c77e5ab 100644
--- a/block/nvme.c
+++ b/block/nvme.c
@@ -57,7 +57,6 @@ typedef struct {
} NVMeRequest;
typedef struct {
- CoQueue free_req_queue;
QemuMutex lock;
/* Fields protected by BQL */
@@ -65,6 +64,7 @@ typedef struct {
uint8_t *prp_list_pages;
/* Fields protected by @lock */
+ CoQueue free_req_queue;
NVMeQueue sq, cq;
int cq_phase;
int free_req_head;
--
2.26.2
- [PULL 00/12] Block patches, Stefan Hajnoczi, 2020/06/24
- [PULL 01/12] minikconf: explicitly set encoding to UTF-8, Stefan Hajnoczi, 2020/06/24
- [PULL 02/12] coroutine: support SafeStack in ucontext backend, Stefan Hajnoczi, 2020/06/24
- [PULL 03/12] coroutine: add check for SafeStack in sigaltstack, Stefan Hajnoczi, 2020/06/24
- [PULL 04/12] configure: add flags to support SafeStack, Stefan Hajnoczi, 2020/06/24
- [PULL 05/12] check-block: enable iotests with SafeStack, Stefan Hajnoczi, 2020/06/24
- [PULL 06/12] block/nvme: poll queues without q->lock, Stefan Hajnoczi, 2020/06/24
- [PULL 07/12] block/nvme: drop tautologous assertion, Stefan Hajnoczi, 2020/06/24
- [PULL 08/12] block/nvme: don't access CQE after moving cq.head, Stefan Hajnoczi, 2020/06/24
- [PULL 09/12] block/nvme: switch to a NVMeRequest freelist, Stefan Hajnoczi, 2020/06/24
- [PULL 10/12] block/nvme: clarify that free_req_queue is protected by q->lock,
Stefan Hajnoczi <=
- [PULL 11/12] block/nvme: keep BDRVNVMeState pointer in NVMeQueuePair, Stefan Hajnoczi, 2020/06/24
- [PULL 12/12] block/nvme: support nested aio_poll(), Stefan Hajnoczi, 2020/06/24
- Re: [PULL 00/12] Block patches, Peter Maydell, 2020/06/25