Re: [PATCH v2 00/16] Crazy shit around -global (pardon my french)

[no-reply]

Patchew URL: 
20200622094227.1271650-1-armbru@redhat.com/">https://patchew.org/QEMU/20200622094227.1271650-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v2 00/16] Crazy shit around -global (pardon my french)
Type: series
Message-id: 20200622094227.1271650-1-armbru@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200622094227.1271650-1-armbru@redhat.com -> 
patchew/20200622094227.1271650-1-armbru@redhat.com
Switched to a new branch 'test'
f0116ee sd/milkymist-memcard: Fix error API violation
3ce05b4 sd/pxa2xx_mmci: Don't crash on pxa2xx_mmci_init() error
7bb382e arm/aspeed: Drop aspeed_board_init_flashes() parameter @errp
7fc39f8 qdev: Make qdev_prop_set_drive() match the other helpers
a1bad90 qdev: Reject chardev property override
b73765e qdev: Reject drive property override
34072ae qdev: Improve netdev property override error a bit
fa6bc3e qdev: Eliminate get_pointer(), set_pointer()
2e22ad2 blockdev: Deprecate -drive with bogus interface type
2fdd4f4 docs/qdev-device-use.txt: Update section "Default Devices"
3bb6131 fdc: Deprecate configuring floppies with -global isa-fdc
1442ef5 fdc: Open-code fdctrl_init_isa()
6ab9dc2 fdc: Reject clash between -drive if=floppy and -global isa-fdc
00e64a2 iotests/172: Cover -global floppy.drive=...
40c2844 iotests/172: Cover empty filename and multiple use of drives
ba868ba iotests/172: Include "info block" in test output

=== OUTPUT BEGIN ===
1/16 Checking commit ba868baf44f7 (iotests/172: Include "info block" in test 
output)
2/16 Checking commit 40c28442f546 (iotests/172: Cover empty filename and 
multiple use of drives)
ERROR: trailing whitespace
#48: FILE: tests/qemu-iotests/172.out:190:
+Testing: -fdb $

total: 1 errors, 0 warnings, 86 lines checked

Patch 2/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/16 Checking commit 00e64a2b1a99 (iotests/172: Cover -global floppy.drive=...)
4/16 Checking commit 6ab9dc296d08 (fdc: Reject clash between -drive if=floppy 
and -global isa-fdc)
5/16 Checking commit 1442ef5c1dad (fdc: Open-code fdctrl_init_isa())
6/16 Checking commit 3bb61318d607 (fdc: Deprecate configuring floppies with 
-global isa-fdc)
7/16 Checking commit 2fdd4f45b355 (docs/qdev-device-use.txt: Update section 
"Default Devices")
8/16 Checking commit 2e22ad2cf40d (blockdev: Deprecate -drive with bogus 
interface type)
9/16 Checking commit fa6bc3ea041f (qdev: Eliminate get_pointer(), set_pointer())
10/16 Checking commit 34072ae828ca (qdev: Improve netdev property override 
error a bit)
11/16 Checking commit b73765e2d86c (qdev: Reject drive property override)
12/16 Checking commit a1bad90fffeb (qdev: Reject chardev property override)
13/16 Checking commit 7fc39f8555b1 (qdev: Make qdev_prop_set_drive() match the 
other helpers)
14/16 Checking commit 7bb382e31bf4 (arm/aspeed: Drop 
aspeed_board_init_flashes() parameter @errp)
15/16 Checking commit 3ce05b4e108e (sd/pxa2xx_mmci: Don't crash on 
pxa2xx_mmci_init() error)
16/16 Checking commit f0116ee141ee (sd/milkymist-memcard: Fix error API 
violation)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200622094227.1271650-1-armbru@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200622094227.1271650-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com