qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 03/13] qcow2.py: move qcow2 format classes to separate mod


From: Eric Blake
Subject: Re: [PATCH v5 03/13] qcow2.py: move qcow2 format classes to separate module
Date: Mon, 8 Jun 2020 16:05:52 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0

On 6/6/20 3:17 AM, Vladimir Sementsov-Ogievskiy wrote:
We are going to enhance qcow2 format parsing by adding more structure
classes. Let's split format parsing from utility code.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
  tests/qemu-iotests/qcow2.py        | 160 +-------------------------
  tests/qemu-iotests/qcow2_format.py | 173 +++++++++++++++++++++++++++++
  2 files changed, 177 insertions(+), 156 deletions(-)
  create mode 100644 tests/qemu-iotests/qcow2_format.py


+++ b/tests/qemu-iotests/qcow2_format.py
@@ -0,0 +1,173 @@
+# Library for manipulations with qcow2 image
+#

Any copyright line added in 2/13 should also be added here. Again, that can be a followup for authorship reasons if we decide what copyright line is best.

Otherwise, this is a clean code motion patch where the difference in line length is the boilerplate header and the change to imports.

Reviewed-by: Eric Blake <eblake@redhat.com>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]