Re: [PATCH v3 00/16] python: add mypy support to python/qemu

[John Snow]

On 6/5/20 5:26 AM, Kevin Wolf wrote:
> Am 04.06.2020 um 22:22 hat John Snow geschrieben:
>> Based-on: 20200604195252.20739-1-jsnow@redhat.com
>>
>> This series is extracted from my larger series that attempted to bundle
>> our python module as an installable module. These fixes don't require that,
>> so they are being sent first as I think there's less up for debate in here.
>>
>> This requires my "refactor shutdown" patch as a pre-requisite.
> 
> You didn't like my previous R-b? Here's a new one. :-)
> 
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
> 

I felt like I should address the feedback, and though I could have
applied the R-B to patches I didn't change, it was ... faster to just
re-send it.

Serious question: How do you apply people's R-Bs to your patches? At the
moment, it's pretty manually intensive for me. I use stgit and I pop all
of the patches off (stg pop -n 100), and then one-at-a-time I `stg push;
stg edit` and copy-paste the R-B into it.

It's easier when I'm just pulling other people's patches from the ML,
the patches tool handles it for me. It's updating my own patches that's
a drag and prone to error.

--js