|
From: | Eric Blake |
Subject: | Re: [PATCH v4] osdep: Make MIN/MAX evaluate arguments only once |
Date: | Fri, 5 Jun 2020 09:03:37 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/5/20 3:24 AM, David Edmondson wrote:
On Thursday, 2020-06-04 at 16:52:36 -05, Eric Blake wrote:/* Minimum function that returns zero only iff both values are zero.Not your change, but "only" is unnecessary here (or iff -> if).
Indeed. Whoever picks this up could make that change (although I have no idea which tree will be best for this patch, so I may just adopt it as a miscellaneous patch through one of my own if there are no objections after a few days...).
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |