Re: [PATCH v4 04/12] qcow2_format.py: use tuples instead of lists for fi

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 04/12] qcow2_format.py: use tuples instead of lists for fi

From:	Andrey Shinkevich
Subject:	Re: [PATCH v4 04/12] qcow2_format.py: use tuples instead of lists for fields
Date:	Fri, 5 Jun 2020 11:20:36 +0000

Reviewed-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>

From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Sent: Thursday, June 4, 2020 8:41 PM
To: qemu-block@nongnu.org <qemu-block@nongnu.org>
Cc: qemu-devel@nongnu.org <qemu-devel@nongnu.org>; mreitz@redhat.com <mreitz@redhat.com>; kwolf@redhat.com <kwolf@redhat.com>; eblake@redhat.com <eblake@redhat.com>; Denis Lunev <den@virtuozzo.com>; Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>; Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Subject: [PATCH v4 04/12] qcow2_format.py: use tuples instead of lists for fields

No need in lists: it's a constant variable.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
tests/qemu-iotests/qcow2_format.py | 40 +++++++++++++++---------------
1 file changed, 20 insertions(+), 20 deletions(-)

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v4 01/12] qcow2.py: python style fixes, (continued)
- [PATCH v4 02/12] qcow2.py: move qcow2 format classes to separate module, Vladimir Sementsov-Ogievskiy, 2020/06/04
  - Re: [PATCH v4 02/12] qcow2.py: move qcow2 format classes to separate module, Andrey Shinkevich, 2020/06/05
  - Re: [PATCH v4 02/12] qcow2.py: move qcow2 format classes to separate module, Eric Blake, 2020/06/05
    - Re: [PATCH v4 02/12] qcow2.py: move qcow2 format classes to separate module, Vladimir Sementsov-Ogievskiy, 2020/06/06
    - Re: [PATCH v4 02/12] qcow2.py: move qcow2 format classes to separate module, Eric Blake, 2020/06/08
- [PATCH v4 03/12] qcow2_format.py: drop new line printing at end of dump(), Vladimir Sementsov-Ogievskiy, 2020/06/04
  - Re: [PATCH v4 03/12] qcow2_format.py: drop new line printing at end of dump(), Andrey Shinkevich, 2020/06/05
- [PATCH v4 04/12] qcow2_format.py: use tuples instead of lists for fields, Vladimir Sementsov-Ogievskiy, 2020/06/04
  - Re: [PATCH v4 04/12] qcow2_format.py: use tuples instead of lists for fields, Andrey Shinkevich <=
  - Re: [PATCH v4 04/12] qcow2_format.py: use tuples instead of lists for fields, Eric Blake, 2020/06/05
    - Re: [PATCH v4 04/12] qcow2_format.py: use tuples instead of lists for fields, Vladimir Sementsov-Ogievskiy, 2020/06/06
- [PATCH v4 07/12] qcow2_format.py: separate generic functionality of structure classes, Vladimir Sementsov-Ogievskiy, 2020/06/04
  - Re: [PATCH v4 07/12] qcow2_format.py: separate generic functionality of structure classes, Andrey Shinkevich, 2020/06/05
    - Re: [PATCH v4 07/12] qcow2_format.py: separate generic functionality of structure classes, Vladimir Sementsov-Ogievskiy, 2020/06/05
- [PATCH v4 05/12] qcow2_format.py: use modern string formatting, Vladimir Sementsov-Ogievskiy, 2020/06/04
  - Re: [PATCH v4 05/12] qcow2_format.py: use modern string formatting, Andrey Shinkevich, 2020/06/05
- [PATCH v4 06/12] qcow2_format.py: use strings to specify c-type of struct fields, Vladimir Sementsov-Ogievskiy, 2020/06/04
  - Re: [PATCH v4 06/12] qcow2_format.py: use strings to specify c-type of struct fields, Andrey Shinkevich, 2020/06/05
  - Re: [PATCH v4 06/12] qcow2_format.py: use strings to specify c-type of struct fields, Eric Blake, 2020/06/05

Prev by Date: Re: [PATCH for-5.1] qcow2: Don't open images with a backing file and the data-file-raw bit
Next by Date: Re: [PATCH v4 05/12] qcow2_format.py: use modern string formatting
Previous by thread: [PATCH v4 04/12] qcow2_format.py: use tuples instead of lists for fields
Next by thread: Re: [PATCH v4 04/12] qcow2_format.py: use tuples instead of lists for fields
Index(es):
- Date
- Thread