qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 6/6] iotests: Dump QCOW2 image metadata in JSON format wit


From: Eric Blake
Subject: Re: [PATCH v3 6/6] iotests: Dump QCOW2 image metadata in JSON format with qcow2.py
Date: Tue, 2 Jun 2020 12:40:54 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0

On 6/1/20 8:48 AM, Andrey Shinkevich wrote:
Represent QCOW2 metadata dumping with qcow2.py script in JSON format

{
     "QCOW2_header_extensions": [
         {
             "Header_extension": "Feature table",
             "magic": "0x6803f857",
             "length": 192,
             "data_str": "<binary>"
         },
         {
             "Header_extension": "Bitmaps",
             "magic": "0x23852875",
             "length": 24,
             "data": {
                 "nb_bitmaps": 2,
                 "reserved32": 0,

Lengthy, but for a debug tool that's sometimes what you need.

Suggested-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
---
  tests/qemu-iotests/qcow2.py | 108 ++++++++++++++++++++++++++++++++++++++++++--
  1 file changed, 105 insertions(+), 3 deletions(-)


My python is not the strongest, but nothing jumped out at me, and the end results look good.

Reviewed-by: Eric Blake <eblake@redhat.com>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]