[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v6 2/5] block: consolidate blocksize properties consistency c
From: |
Paul Durrant |
Subject: |
RE: [PATCH v6 2/5] block: consolidate blocksize properties consistency checks |
Date: |
Thu, 28 May 2020 08:22:25 +0100 |
> -----Original Message-----
> From: Roman Kagan <rvkagan@yandex-team.ru>
> Sent: 27 May 2020 13:45
> To: qemu-devel@nongnu.org
> Cc: Kevin Wolf <kwolf@redhat.com>; xen-devel@lists.xenproject.org; Gerd
> Hoffmann <kraxel@redhat.com>;
> Daniel P. Berrangé <berrange@redhat.com>; Paolo Bonzini
> <pbonzini@redhat.com>; Anthony Perard
> <anthony.perard@citrix.com>; Laurent Vivier <laurent@vivier.eu>; Max Reitz
> <mreitz@redhat.com>; qemu-
> block@nongnu.org; Philippe Mathieu-Daudé <philmd@redhat.com>; Eric Blake
> <eblake@redhat.com>; Paul
> Durrant <paul@xen.org>; Fam Zheng <fam@euphon.net>; John Snow
> <jsnow@redhat.com>; Michael S. Tsirkin
> <mst@redhat.com>; Eduardo Habkost <ehabkost@redhat.com>; Keith Busch
> <kbusch@kernel.org>; Stefano
> Stabellini <sstabellini@kernel.org>; Stefan Hajnoczi <stefanha@redhat.com>
> Subject: [PATCH v6 2/5] block: consolidate blocksize properties consistency
> checks
>
> Several block device properties related to blocksize configuration must
> be in certain relationship WRT each other: physical block must be no
> smaller than logical block; min_io_size, opt_io_size, and
> discard_granularity must be a multiple of a logical block.
>
> To ensure these requirements are met, add corresponding consistency
> checks to blkconf_blocksizes, adjusting its signature to communicate
> possible error to the caller. Also remove the now redundant consistency
> checks from the specific devices.
>
> Signed-off-by: Roman Kagan <rvkagan@yandex-team.ru>
Reviewed-by: Paul Durrant <paul@xen.org>
- [PATCH v6 0/5] block: enhance handling of size-related BlockConf properties, Roman Kagan, 2020/05/27
- [PATCH v6 1/5] virtio-blk: store opt_io_size with correct size, Roman Kagan, 2020/05/27
- [PATCH v6 2/5] block: consolidate blocksize properties consistency checks, Roman Kagan, 2020/05/27
- [PATCH v6 3/5] qdev-properties: blocksize: use same limits in code and description, Roman Kagan, 2020/05/27
- [PATCH v6 5/5] block: lift blocksize property limit to 2 MiB, Roman Kagan, 2020/05/27
- [PATCH v6 4/5] block: make size-related BlockConf properties accept size suffixes, Roman Kagan, 2020/05/27