Re: [PATCH v5 0/5] block: widen and check consistency of size-related BlockConf properties

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [PATCH v5 0/5] block: widen and check consistency of size-related 
BlockConf properties
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
6611c53 block: lift blocksize property limit to 2 MiB
1efe094 block: make size-related BlockConf properties accept size suffixes
f9d88df qdev-properties: blocksize: use same limits in code and description
bee66cf block: consolidate blocksize properties consistency checks
8b2fdc1 virtio-blk: store opt_io_size with correct size

=== OUTPUT BEGIN ===
1/5 Checking commit 8b2fdc1b18b2 (virtio-blk: store opt_io_size with correct 
size)
2/5 Checking commit bee66cfde76f (block: consolidate blocksize properties 
consistency checks)
3/5 Checking commit f9d88df4c03e (qdev-properties: blocksize: use same limits 
in code and description)
4/5 Checking commit 1efe094b7637 (block: make size-related BlockConf properties 
accept size suffixes)
ERROR: line over 90 characters
#200: FILE: hw/core/qdev-properties.c:1244:
+                  "Property %s.%s doesn't take value '%" PRId64 "', it's not a 
power of 2",

total: 1 errors, 0 warnings, 1070 lines checked

Patch 4/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/5 Checking commit 6611c538915a (block: lift blocksize property limit to 2 MiB)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden