Re: [PATCH RFC v2 5/5] iotests: add 287 for block-dirty-bitmap-populate

[Eric Blake]

On 5/13/20 10:49 PM, John Snow wrote:
> Give block-dirty-bitmap-populate a workout.
>
> Signed-off-by: John Snow <address@hidden>
> ---
>   tests/qemu-iotests/287     |  242 ++
>   tests/qemu-iotests/287.out | 4544 ++++++++++++++++++++++++++++++++++++

Sheesh, that output file is a workout indeed.

>   tests/qemu-iotests/group   |    1 +
>   3 files changed, 4787 insertions(+)
>   create mode 100755 tests/qemu-iotests/287
>   create mode 100644 tests/qemu-iotests/287.out

287 has been created in the meantime (commit dd488fc1c00); we'll have to 
rebase.  (Vladimir's series to rename iotests to something sensible 
instead of three digits may help...)

> +
> +class Drive:
> +    def __init__(self, path, vm):
> +        self.path = path
> +        self.vm = vm
> +        self.fmt = None
> +        self.size = None
> +        self.node = None
> +
> +    def img_create(self, fmt, size):
> +        self.fmt = fmt
> +        self.size = size
> +        iotests.qemu_img_create('-f', self.fmt, self.path, str(self.size))

Are we creating images with backing files anywhere in this test?  Should 
we be?  (The question of what is allocated in the top layer is more 
interesting to answer when there is a backing layer)

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org