Re: [PATCH v2 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly

[Kevin Wolf]

Am 14.05.2020 um 15:08 hat Kevin Wolf geschrieben:
> Am 29.04.2020 um 16:11 hat Max Reitz geschrieben:
> > v1: https://lists.nongnu.org/archive/html/qemu-block/2020-04/msg01245.html
> > 
> > Branch: https://github.com/XanClic/qemu.git fix-bdrv_make_empty-v2
> > Branch: https://git.xanclic.moe/XanClic/qemu.git fix-bdrv_make_empty-v2
> > 
> > Based-on: <address@hidden>
> >           (“qcow2: Allow resize of images with internal snapshots”)
> > 
> > Hi,
> > 
> > As described in v1’s cover letter (linked above), this series ensures
> > that all calls to BlockDriver.bdrv_make_empty() go through a wrapper
> > bdrv_make_empty() function that ensures the caller does have the
> > necessary permissions.
> 
> Thanks, fixed up the test output in patch 4 and applied to the block
> branch.

Hmm, replication is doing criminal things and this results in:

test-replication: block.c:6899: bdrv_make_empty: Assertion `c->perm & 
(BLK_PERM_WRITE | BLK_PERM_WRITE_UNCHANGED)' failed.

Not your bug, but it breaks 'make check', so it needs to be fixed before
I can send a pull request. I'll see what I can do...

Kevin