[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 2/4] qemu-img: validate image length in img_map
From: |
Eyal Moscovici |
Subject: |
[PATCH v3 2/4] qemu-img: validate image length in img_map |
Date: |
Wed, 13 May 2020 16:36:27 +0300 |
The code handles this case correctly we merely skip the loop. However it
is probably best to return an explicit error.
Reviewed-by: Eric Blake <address@hidden>
Acked-by: Mark Kanda <address@hidden>
Signed-off-by: Eyal Moscovici <address@hidden>
---
qemu-img.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/qemu-img.c b/qemu-img.c
index cc2e4a3799..23e90a99e1 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -3091,6 +3091,11 @@ static int img_map(int argc, char **argv)
}
length = blk_getlength(blk);
+ if (length < 0) {
+ error_report("Failed to get size for '%s'", filename);
+ return 1;
+ }
+
while (curr.start + curr.length < length) {
int64_t offset = curr.start + curr.length;
int64_t n;
--
2.17.2 (Apple Git-113)
- [PATCH v3 0/4] Additional parameters for qemu_img map, Eyal Moscovici, 2020/05/13
- [PATCH v3 1/1] qemu_img: add cvtnum_full to print error reports, Eyal Moscovici, 2020/05/13
- [PATCH v3 2/4] qemu-img: validate image length in img_map,
Eyal Moscovici <=
- [PATCH v3 3/4] qemu-img: refactor dump_map_entry JSON format output, Eyal Moscovici, 2020/05/13
- [PATCH v3 4/4] qemu-img: Add --start-offset and --max-length to map, Eyal Moscovici, 2020/05/13
- Re: [PATCH v3 0/4] Additional parameters for qemu_img map, Eric Blake, 2020/05/13
- [PATCH v3 5/4] iotests: Enhance 223 to cover qemu-img map improvements, Eric Blake, 2020/05/13
- [PATCH v3 5/4] iotests: Enhance 223 to cover qemu-img map improvements, Eric Blake, 2020/05/13
- Re: [PATCH v3 0/4] Additional parameters for qemu_img map, no-reply, 2020/05/13