[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] io/channel.c,io/channel-socket.c: Add yank feature
From: |
Lukas Straub |
Subject: |
Re: [PATCH 2/5] io/channel.c,io/channel-socket.c: Add yank feature |
Date: |
Mon, 11 May 2020 22:00:42 +0200 |
On Mon, 11 May 2020 12:51:46 +0100
Daniel P. Berrangé <address@hidden> wrote:
> On Mon, May 11, 2020 at 01:14:41PM +0200, Lukas Straub wrote:
> > Add qio_channel_set_yank function to channel and to channel-socket,
> > which will register a yank function. The yank function calls
> > shutdown() on the socket.
> >
> > Signed-off-by: Lukas Straub <address@hidden>
> > ---
> > Makefile.objs | 1 +
> > include/io/channel-socket.h | 1 +
> > include/io/channel.h | 12 ++++++++++++
> > io/channel-socket.c | 29 +++++++++++++++++++++++++++++
> > io/channel.c | 9 +++++++++
> > 5 files changed, 52 insertions(+)
>
> Assuming we want the yank feature (which I'm not entirely convinced
> of), then I don't think any of this addition should exist. The
> QIOChannel class already provides a "qio_channel_shutdown" method
> which can be invoked. The layer above which is using the QIOChannel
> should be calling this existing qio_channel_shutdown method in
> response to any yank request. The I/O layer shouldn't have any
> direct dependancy on the yank feature.
Having the code here simplifys the code in the other places.
Regards,
Lukas Straub
>
> Regards,
> Daniel
pgp5nWM3UPmhm.pgp
Description: OpenPGP digital signature
- [PATCH 0/5] Introduce 'yank' oob qmp command to recover from hanging qemu, Lukas Straub, 2020/05/11
- [PATCH 3/5] block/nbd.c: Add yank feature, Lukas Straub, 2020/05/11
- Re: [PATCH 3/5] block/nbd.c: Add yank feature, Dr. David Alan Gilbert, 2020/05/11
- Re: [PATCH 3/5] block/nbd.c: Add yank feature, Lukas Straub, 2020/05/11
- Re: [PATCH 3/5] block/nbd.c: Add yank feature, Dr. David Alan Gilbert, 2020/05/11
- Re: [PATCH 3/5] block/nbd.c: Add yank feature, Daniel P . Berrangé, 2020/05/12
- Re: [PATCH 3/5] block/nbd.c: Add yank feature, Lukas Straub, 2020/05/15
- Re: [PATCH 3/5] block/nbd.c: Add yank feature, Daniel P . Berrangé, 2020/05/15
- Re: [PATCH 3/5] block/nbd.c: Add yank feature, Lukas Straub, 2020/05/15
- Re: [PATCH 3/5] block/nbd.c: Add yank feature, Daniel P . Berrangé, 2020/05/15