qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Compress lines for immediate return


From: Laurent Vivier
Subject: Re: [PATCH v2] Compress lines for immediate return
Date: Mon, 4 May 2020 11:51:29 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0

Le 03/04/2020 à 14:53, Stefan Hajnoczi a écrit :
> On Wed, Apr 01, 2020 at 10:23:14PM +0530, Simran Singhal wrote:
>> Compress two lines into a single line if immediate return statement is found.
>>
>> It also remove variables progress, val, data, ret and sock
>> as they are no longer needed.
>>
>> Remove space between function "mixer_load" and '(' to fix the
>> checkpatch.pl error:-
>> ERROR: space prohibited between function name and open parenthesis '('
>>
>> Done using following coccinelle script:
>> @@
>> local idexpression ret;
>> expression e;
>> @@
>>
>> -ret =
>> +return
>>      e;
>> -return ret;
>>
>> Signed-off-by: Simran Singhal <address@hidden>
>> ---
>> Changes in v2:
>>      -Added coccinelle script wrote for changes in commit message.
>>
>>  block/file-posix.c      | 3 +--
>>  block/nfs.c             | 3 +--
>>  block/nvme.c            | 4 +---
>>  block/vhdx.c            | 3 +--
>>  hw/audio/ac97.c         | 4 +---
>>  hw/audio/adlib.c        | 5 +----
>>  hw/display/cirrus_vga.c | 4 +---
>>  migration/ram.c         | 4 +---
>>  ui/gtk.c                | 3 +--
>>  util/qemu-sockets.c     | 5 +----
>>  10 files changed, 10 insertions(+), 28 deletions(-)
> 
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> 

Applied to my trivial-patches branch.

Thanks,
Laurent


Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]